Passcodes | Use correct CTA format on RegistrationPasscode email #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldlink
changed the title
raphaelkabo
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
When trying to apply terraform for this email template in https://github.com/guardian/identity-platform, we kept getting unhelpful 400, 404, or 409 errors.
After much debugging and using the following command when trying to apply terraform, I was able to output the terraform raw logs to a file.
This helpfully returns a full error message rather than just the status code. After much digging, the reason this template wasn't getting applied is that the CTA for the one time passcode had to be in the following format
$${oneTimePasscode}which it then shortens to the format it needs, i.e the one that we tried using (
${oneTimePasscode}).This PR updates that CTA, and a separate PR will be created in identity-platform for applying the terraform configuration once this one is merged in.