Geolocation | Remove GU_geo_country cookie, stop checking CMP for geolocation #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
coldlink
requested changes
May 15, 2024
raphaelkabo
force-pushed
the
rk/geolocation-fixes
branch
2 times, most recently
from
997cac4
to
5c16516
Compare
|
also this commit needs to be reworded, has |
raphaelkabo
force-pushed
the
rk/geolocation-fixes
branch
from
5c16516
to
edb03dc
Compare
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
raphaelkabo
force-pushed
the
rk/geolocation-fixes
branch
from
edb03dc
to
11b2623
Compare
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
coldlink
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This prepares the ground for adding some new registration newsletter consents in a subsequent PR.
The key changes are:
GU_geo_countrycookie, in favour of theX-GU-GeolocationHTTP header sent from Fastly. In Cypress, because mocking a header in E2E tests isn't worth the hassle, we mock the geolocation state with thecypress-mocked-statecookie we used elsewhere.registrationLocationin Okta, and always show geolocated newsletters in the onboarding flow. We remove all non-geolocated newsletter mappings and all uses of thePermissionedGeolocationtype - it's now justGeolocation.Tests