-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway | Replace onboarding flow with new account review and newsletters pages #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
March 28, 2024 10:09
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
March 28, 2024 12:19
fe5993e
to
869dbec
Compare
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
April 2, 2024 10:53
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
April 3, 2024 13:51
dc78848
to
9524a59
Compare
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
April 3, 2024 15:35
9524a59
to
f9fe979
Compare
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
April 3, 2024 15:37
coldlink
requested changes
Apr 4, 2024
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
April 4, 2024 11:18
c5d26b6
to
454ba2d
Compare
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
April 4, 2024 11:18
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
April 4, 2024 13:05
454ba2d
to
9076c0b
Compare
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
May 21, 2024 10:11
5fe72bd
to
e54c76d
Compare
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
May 21, 2024 10:19
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
May 21, 2024 11:14
e54c76d
to
5d688c0
Compare
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
May 21, 2024 11:26
coldlink
previously approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking amazing now! Really brilliant work. 🌵
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
May 21, 2024 13:57
abf39c4
to
7103347
Compare
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
May 21, 2024 14:12
7103347
to
f04390b
Compare
raphaelkabo
requested review from
guardian-ci
and removed request for
guardian-ci
May 21, 2024 14:46
This was causing a Cypress error about 'postMessage' (???) Co-authored-by: Mahesh Makani <mahesh@makani.dev>
raphaelkabo
force-pushed
the
rk/remove-onboarding-flow
branch
from
May 22, 2024 10:08
49c3261
to
7410c7e
Compare
coldlink
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All green 🌲
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the consents framework (a kind of onboarding flow) to simplify post-registration behaviour. It's part of a wider redesign project to improve the mandatory registration experience for our users - this is the part of the redesign where we change the flow sequence, rather than the visual frontend designs.
New flow
/welcome/review
, which allows them to select their consents for personalized advertising and marketing.The geolocation-based behaviour is a MVP test of a 'next best action' framework for user registrations. In future, we may select a next best action for the user after they confirm consents, based on geolocation, login type, login app, and other factors.
Changes
/welcome/review
, which is shown after password set (for email registrations) or social registration confirmed (for social registrations). This page displays consent toggles for personalized advertising and marketing, along with supporting text./welcome/newsletters
, which is shown for some users (see flow section above). This displays new-style checkboxes for a set of geolocation-appropriate newsletters, along with supporting text./consents/*
as a final return URL page to use/welcome/review
instead.New designs
Newsletters page designs
Tests
As well as our new Cypress tests, we're using this manual testing matrix to ensure everything behaves the way we expect:
Related PRs