Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway | Replace onboarding flow with new account review and newsletters pages #2653

Merged
merged 7 commits into from
May 22, 2024

Conversation

raphaelkabo
Copy link
Contributor

@raphaelkabo raphaelkabo commented Mar 26, 2024

This PR removes the consents framework (a kind of onboarding flow) to simplify post-registration behaviour. It's part of a wider redesign project to improve the mandatory registration experience for our users - this is the part of the redesign where we change the flow sequence, rather than the visual frontend designs.

New flow

  • New users, after verifying their social login/setting their password, will now go to the page /welcome/review, which allows them to select their consents for personalized advertising and marketing.
  • The submit button on that page will take them to the URL from which they originated (a newspaper article, for instance).
  • The exception is if the user is currently geolocated in Australia or the US. In this case, they will be taken to a page where they can subscribe to a small set of newsletters. Clicking submit on that page will take them to the originating URL.

The geolocation-based behaviour is a MVP test of a 'next best action' framework for user registrations. In future, we may select a next best action for the user after they confirm consents, based on geolocation, login type, login app, and other factors.

Changes

  • Remove the consents framework and its support files, tests, etc.
  • Create a new page, /welcome/review, which is shown after password set (for email registrations) or social registration confirmed (for social registrations). This page displays consent toggles for personalized advertising and marketing, along with supporting text.
  • Create a new page, /welcome/newsletters, which is shown for some users (see flow section above). This displays new-style checkboxes for a set of geolocation-appropriate newsletters, along with supporting text.
  • Change some wording on the password set page.
  • Update tests which used /consents/* as a final return URL page to use /welcome/review instead.
  • Add a new ETE test suite for the new account review page and the newsletters page.
  • Add Storybook stories for the new account review page and newsletters page.
  • Add a flag in the change password handler for when the password is being changed as part of a new account registration, and make use of this flag in the OAuth callback route to send the user correctly to the new account review page when they're registering via an app.

New designs

Set password page Password set page New account review page
profile thegulocal com_welcome_a4FZleGPDMMuMq4F05mBug Nl62lV-0ruMIY9M4 UJiBLrLKkefnxZiZhzJH1mHY9EjQZGqoZYi9GyEnHhN5BU62eAN1JNEqLunEMc5r1dT2lor5D7lVODBK7nprhRFaT6Mhb9B9UHFQaH_4D2KutBOJJeh_eu773C-tlyR_IVnI_x1qxRxDKMJpQUmQt08kgw_ref=https%3A%2 profile thegulocal com_welcome_fkefO81DbuUsIAdRr4engw ZDqB5xsgeG2UazSY jXwmkqH2pFk9vfe60GgKKPTVt59TP6ikB9zbXj4Z7WKeTJWkmmZLVG-g1R1tnM8eU5ZrmhwyUOOgb6T2uskupBnEwFFtGSjNlUhO86ZPg8B3fc9JiUwlbfjhgYFKiQKicGXdKUa13an9icjXobDi9CUQKw_ref=https%3A%2 profile thegulocal com_welcome_review_ref=https%3A%2F%2Fprofile thegulocal com%2Fregister%2Femail refViewId=lujvj3x1jasorzuxae2g returnUrl=https%3A%2F%2Fm code dev-theguardian com%2F

Newsletters page designs

US AU Some selected Error fetching newsletters
Screenshot 2024-05-20 at 14 44 17 Screenshot 2024-05-20 at 14 44 23 Screenshot 2024-05-20 at 14 43 48 Screenshot 2024-05-20 at 11 18 55

Tests

As well as our new Cypress tests, we're using this manual testing matrix to ensure everything behaves the way we expect:

Screenshot 2024-05-20 at 15 15 16
  • Tested in CODE
  • Tested in PROD

Related PRs

@raphaelkabo raphaelkabo added the Do not merge ⚠ This PR is a work in progress label Mar 26, 2024
@raphaelkabo raphaelkabo requested review from guardian-ci and removed request for guardian-ci March 28, 2024 10:09
@raphaelkabo raphaelkabo requested review from guardian-ci and removed request for guardian-ci April 2, 2024 10:53
@raphaelkabo raphaelkabo changed the title Remove onboarding flow Gateway | Remove onboarding flow Apr 3, 2024
@raphaelkabo raphaelkabo removed the Do not merge ⚠ This PR is a work in progress label Apr 3, 2024
@raphaelkabo raphaelkabo marked this pull request as ready for review April 3, 2024 14:06
@raphaelkabo raphaelkabo requested a review from a team as a code owner April 3, 2024 14:06
@raphaelkabo raphaelkabo requested review from guardian-ci and removed request for guardian-ci April 3, 2024 15:37
src/client/pages/NewAccountReview.tsx Outdated Show resolved Hide resolved
src/client/pages/NewAccountReview.tsx Outdated Show resolved Hide resolved
src/server/routes/welcome.ts Outdated Show resolved Hide resolved
@raphaelkabo raphaelkabo requested review from guardian-ci and removed request for guardian-ci April 4, 2024 11:18
@raphaelkabo raphaelkabo requested review from guardian-ci and removed request for guardian-ci May 21, 2024 10:19
@raphaelkabo raphaelkabo requested review from guardian-ci and removed request for guardian-ci May 21, 2024 11:26
@raphaelkabo raphaelkabo removed the Do not merge ⚠ This PR is a work in progress label May 21, 2024
coldlink
coldlink previously approved these changes May 21, 2024
Copy link
Member

@coldlink coldlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking amazing now! Really brilliant work. 🌵

@raphaelkabo raphaelkabo requested review from guardian-ci and removed request for guardian-ci May 21, 2024 14:46
This was causing a Cypress error about 'postMessage' (???)

Co-authored-by: Mahesh Makani <mahesh@makani.dev>
@raphaelkabo raphaelkabo removed the request for review from guardian-ci May 22, 2024 10:08
Copy link
Member

@coldlink coldlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green 🌲

@raphaelkabo raphaelkabo merged commit 4d2f428 into main May 22, 2024
27 checks passed
@raphaelkabo raphaelkabo deleted the rk/remove-onboarding-flow branch May 22, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants