Fix dotcom-rendering kinesis stream #6748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
commented
Dec 9, 2022
|
Size Change: +39 B (0%) Total Size: 2.38 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Sets log4js file mode to
0o640and adds the kinesis user to thefrontenduser groupWhy?
Looks like our logging has been broken for a long while, it'd be nice to have functional logging for the fronts launch!
An update to log4js log4js-node/log4js-node#1141 changed the default log file permissions from
0o644to0o600which has prevented our Kinesis agent from being able to read our log files. By setting the permissions to0o640we allow anyone in thefrontendgroup to read the file.