Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate chromatic workflows #6619

Merged
merged 9 commits into from Dec 2, 2022
Merged

Separate chromatic workflows #6619

merged 9 commits into from Dec 2, 2022

Conversation

joecowton1
Copy link
Contributor

@joecowton1 joecowton1 commented Nov 30, 2022 •
edited

What does this change?

Moves each Chromatic run to its own workflow instance and adds dependabot checks to all.

Why?

As we move towards moving DCR into CSNX, it's helpful to have these things separate. We're also now able to run the workflows in parallel, whether or not thats faster I'm not sure at this stage.

@github-actions
Copy link

github-actions bot commented Nov 30, 2022 •
edited

Size Change: 0 B

Total Size: 2.37 MB

ℹ️ View Unchanged
Filename Size
dotcom-rendering/dist/1018.legacy.********************.js 3.72 kB
dotcom-rendering/dist/1067.legacy.********************.js 6.69 kB
dotcom-rendering/dist/1067.modern.********************.js 6.6 kB
dotcom-rendering/dist/1111.legacy.********************.js 4.19 kB
dotcom-rendering/dist/1111.modern.********************.js 4.14 kB
dotcom-rendering/dist/1124.modern.********************.js 8.35 kB
dotcom-rendering/dist/1423.modern.********************.js 3.53 kB
dotcom-rendering/dist/1522.legacy.********************.js 4.01 kB
dotcom-rendering/dist/1784.legacy.********************.js 3.8 kB
dotcom-rendering/dist/1954.modern.********************.js 6.7 kB
dotcom-rendering/dist/251.legacy.********************.js 4.65 kB
dotcom-rendering/dist/2513.legacy.********************.js 2.92 kB
dotcom-rendering/dist/2513.modern.********************.js 2.92 kB
dotcom-rendering/dist/2635.modern.********************.js 6.33 kB
dotcom-rendering/dist/2727.legacy.********************.js 4.28 kB
dotcom-rendering/dist/2850.legacy.********************.js 10 kB
dotcom-rendering/dist/2850.modern.********************.js 10.3 kB
dotcom-rendering/dist/2913.legacy.********************.js 6.77 kB
dotcom-rendering/dist/3014.modern.********************.js 24.6 kB
dotcom-rendering/dist/3039.legacy.********************.js 2.9 kB
dotcom-rendering/dist/3039.modern.********************.js 2.89 kB
dotcom-rendering/dist/3178.legacy.********************.js 5.57 kB
dotcom-rendering/dist/3230.legacy.********************.js 3.3 kB
dotcom-rendering/dist/3420.modern.********************.js 4.01 kB
dotcom-rendering/dist/3428.legacy.********************.js 3.75 kB
dotcom-rendering/dist/3428.modern.********************.js 3.75 kB
dotcom-rendering/dist/3490.legacy.********************.js 23.8 kB
dotcom-rendering/dist/3490.modern.********************.js 23.8 kB
dotcom-rendering/dist/3584.legacy.********************.js 1.8 kB
dotcom-rendering/dist/3584.modern.********************.js 1.8 kB
dotcom-rendering/dist/3750.legacy.********************.js 25.1 kB
dotcom-rendering/dist/385.legacy.********************.js 5.29 kB
dotcom-rendering/dist/385.modern.********************.js 5.29 kB
dotcom-rendering/dist/4026.legacy.********************.js 4.61 kB
dotcom-rendering/dist/4046.legacy.********************.js 7.44 kB
dotcom-rendering/dist/4356.modern.********************.js 4.68 kB
dotcom-rendering/dist/4734.legacy.********************.js 3.79 kB
dotcom-rendering/dist/4834.legacy.********************.js 3.98 kB
dotcom-rendering/dist/4834.modern.********************.js 3.43 kB
dotcom-rendering/dist/5001.modern.********************.js 20.6 kB
dotcom-rendering/dist/5179.modern.********************.js 3.66 kB
dotcom-rendering/dist/5196.legacy.********************.js 6 kB
dotcom-rendering/dist/5226.legacy.********************.js 11 kB
dotcom-rendering/dist/5226.modern.********************.js 10.5 kB
dotcom-rendering/dist/5398.legacy.********************.js 4 kB
dotcom-rendering/dist/5398.modern.********************.js 3.69 kB
dotcom-rendering/dist/5481.legacy.********************.js 3.45 kB
dotcom-rendering/dist/5481.modern.********************.js 3.43 kB
dotcom-rendering/dist/5578.legacy.********************.js 5.05 kB
dotcom-rendering/dist/5578.modern.********************.js 4.99 kB
dotcom-rendering/dist/5814.legacy.********************.js 3.79 kB
dotcom-rendering/dist/5888.modern.********************.js 4.61 kB
dotcom-rendering/dist/5951.legacy.********************.js 3.79 kB
dotcom-rendering/dist/598.legacy.********************.js 3.69 kB
dotcom-rendering/dist/598.modern.********************.js 3.38 kB
dotcom-rendering/dist/6053.legacy.********************.js 4.62 kB
dotcom-rendering/dist/6053.modern.********************.js 4.59 kB
dotcom-rendering/dist/6087.legacy.********************.js 6.21 kB
dotcom-rendering/dist/6131.legacy.********************.js 4.3 kB
dotcom-rendering/dist/6131.modern.********************.js 4.3 kB
dotcom-rendering/dist/6574.modern.********************.js 7.07 kB
dotcom-rendering/dist/6589.legacy.********************.js 7.45 kB
dotcom-rendering/dist/6734.modern.********************.js 4 kB
dotcom-rendering/dist/684.legacy.********************.js 7.56 kB
dotcom-rendering/dist/684.modern.********************.js 7.56 kB
dotcom-rendering/dist/6881.legacy.********************.js 6.08 kB
dotcom-rendering/dist/6881.modern.********************.js 5.57 kB
dotcom-rendering/dist/6918.modern.********************.js 3.77 kB
dotcom-rendering/dist/7154.legacy.********************.js 5.32 kB
dotcom-rendering/dist/7154.modern.********************.js 5.29 kB
dotcom-rendering/dist/7185.legacy.********************.js 3.55 kB
dotcom-rendering/dist/7185.modern.********************.js 3.53 kB
dotcom-rendering/dist/7555.legacy.********************.js 7.76 kB
dotcom-rendering/dist/7555.modern.********************.js 6.37 kB
dotcom-rendering/dist/7576.legacy.********************.js 10.1 kB
dotcom-rendering/dist/7576.modern.********************.js 8.55 kB
dotcom-rendering/dist/7585.legacy.********************.js 5.32 kB
dotcom-rendering/dist/7585.modern.********************.js 5.29 kB
dotcom-rendering/dist/7716.legacy.********************.js 9.16 kB
dotcom-rendering/dist/7731.modern.********************.js 4.94 kB
dotcom-rendering/dist/7800.legacy.********************.js 11.3 kB
dotcom-rendering/dist/7800.modern.********************.js 11.3 kB
dotcom-rendering/dist/7812.modern.********************.js 4.2 kB
dotcom-rendering/dist/7829.modern.********************.js 3.4 kB
dotcom-rendering/dist/8130.modern.********************.js 6.42 kB
dotcom-rendering/dist/8227.legacy.********************.js 3.75 kB
dotcom-rendering/dist/8227.modern.********************.js 3.74 kB
dotcom-rendering/dist/8571.modern.********************.js 5.57 kB
dotcom-rendering/dist/86.legacy.********************.js 3.33 kB
dotcom-rendering/dist/8829.legacy.********************.js 2.98 kB
dotcom-rendering/dist/8995.modern.********************.js 5.31 kB
dotcom-rendering/dist/9394.legacy.********************.js 5.04 kB
dotcom-rendering/dist/9408.legacy.********************.js 5.22 kB
dotcom-rendering/dist/9408.modern.********************.js 5.49 kB
dotcom-rendering/dist/9562.legacy.********************.js 6.45 kB
dotcom-rendering/dist/9613.legacy.********************.js 4.29 kB
dotcom-rendering/dist/9614.legacy.********************.js 21.6 kB
dotcom-rendering/dist/9751.legacy.********************.js 5.89 kB
dotcom-rendering/dist/9861.modern.********************.js 6.21 kB
dotcom-rendering/dist/9933.legacy.********************.js 9.14 kB
dotcom-rendering/dist/9933.modern.********************.js 8.61 kB
dotcom-rendering/dist/AlreadyVisited-importable.legacy.********************.js 5.72 kB
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 5.72 kB
dotcom-rendering/dist/atomIframe.legacy.********************.js 13.5 kB
dotcom-rendering/dist/atomIframe.modern.********************.js 13.4 kB
dotcom-rendering/dist/AudioAtomWrapper-importable.legacy.********************.js 524 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 486 B
dotcom-rendering/dist/bootCmp.legacy.********************.js 37.2 kB
dotcom-rendering/dist/bootCmp.modern.********************.js 33.5 kB
dotcom-rendering/dist/Branding-importable.legacy.********************.js 7.89 kB
dotcom-rendering/dist/Branding-importable.modern.********************.js 7.88 kB
dotcom-rendering/dist/braze-web-sdk-core.legacy.********************.js 36.9 kB
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB
dotcom-rendering/dist/BrazeMessaging-importable.legacy.********************.js 9.11 kB
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 8.1 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.legacy.********************.js 4.75 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 4.45 kB
dotcom-rendering/dist/Carousel-importable.legacy.********************.js 4.87 kB
dotcom-rendering/dist/Carousel-importable.modern.********************.js 4.7 kB
dotcom-rendering/dist/ChartAtomWrapper-importable.legacy.********************.js 284 B
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 275 B
dotcom-rendering/dist/CommentCount-importable.legacy.********************.js 1.53 kB
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 1.51 kB
dotcom-rendering/dist/CommercialMetrics-importable.legacy.********************.js 4.26 kB
dotcom-rendering/dist/CommercialMetrics-importable.modern.********************.js 3.38 kB
dotcom-rendering/dist/CoreVitals-importable.legacy.********************.js 5.12 kB
dotcom-rendering/dist/CoreVitals-importable.modern.********************.js 9.91 kB
dotcom-rendering/dist/debug.js 1.75 kB
dotcom-rendering/dist/DiscussionContainer-importable.legacy.********************.js 3.86 kB
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 3.61 kB
dotcom-rendering/dist/DiscussionMeta-importable.legacy.********************.js 2.01 kB
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 1.97 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.legacy.********************.js 1.67 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 1.59 kB
dotcom-rendering/dist/dynamicImport.legacy.********************.js 22 kB
dotcom-rendering/dist/dynamicImport.modern.********************.js 21.5 kB
dotcom-rendering/dist/EditionDropdown-importable.legacy.********************.js 4.14 kB
dotcom-rendering/dist/EditionDropdown-importable.modern.********************.js 3.22 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.legacy.********************.js 4.35 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.15 kB
dotcom-rendering/dist/embedIframe.legacy.********************.js 13.5 kB
dotcom-rendering/dist/embedIframe.modern.********************.js 13.4 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.legacy.********************.js 7.22 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 6.66 kB
dotcom-rendering/dist/FetchCommentCounts-importable.legacy.********************.js 7.52 kB
dotcom-rendering/dist/FetchCommentCounts-importable.modern.********************.js 6.99 kB
dotcom-rendering/dist/FetchOnwardsData-importable.legacy.********************.js 2.76 kB
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 2.71 kB
dotcom-rendering/dist/FilterButton-importable.legacy.********************.js 2.94 kB
dotcom-rendering/dist/FilterButton-importable.modern.********************.js 2.35 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.legacy.********************.js 795 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 757 B
dotcom-rendering/dist/FocusStyles-importable.legacy.********************.js 4.73 kB
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 4.67 kB
dotcom-rendering/dist/frontend.server.js 536 kB
dotcom-rendering/dist/ga.legacy.********************.js 20 kB
dotcom-rendering/dist/ga.modern.********************.js 19.3 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.legacy.********************.js 2.16 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 2.1 kB
dotcom-rendering/dist/GetMatchNav-importable.legacy.********************.js 7.82 kB
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 7.69 kB
dotcom-rendering/dist/GetMatchStats-importable.legacy.********************.js 5.36 kB
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 6.6 kB
dotcom-rendering/dist/GetMatchTabs-importable.legacy.********************.js 2.92 kB
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.83 kB
dotcom-rendering/dist/guardian-braze-components-banner.js 11.4 kB
dotcom-rendering/dist/guardian-braze-components-banner.legacy.********************.js 11.8 kB
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 11.6 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.js 10.1 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.legacy.********************.js 10.1 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 9.78 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.legacy.********************.js 285 B
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 277 B
dotcom-rendering/dist/HeaderTopBar-importable.legacy.********************.js 3.68 kB
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 3.61 kB
dotcom-rendering/dist/initDiscussion.legacy.********************.js 32 kB
dotcom-rendering/dist/initDiscussion.modern.********************.js 29 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.legacy.********************.js 5.84 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 4.75 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.legacy.********************.js 4.53 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 4.37 kB
dotcom-rendering/dist/islands.legacy.********************.js 32.9 kB
dotcom-rendering/dist/islands.modern.********************.js 29.5 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.legacy.********************.js 2.35 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 1.98 kB
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.legacy.********************.js 289 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 281 B
dotcom-rendering/dist/LabsHeader-importable.legacy.********************.js 6.9 kB
dotcom-rendering/dist/LabsHeader-importable.modern.********************.js 8.06 kB
dotcom-rendering/dist/Links-importable.legacy.********************.js 1.99 kB
dotcom-rendering/dist/Links-importable.modern.********************.js 1.96 kB
dotcom-rendering/dist/LiveBlogEpic-importable.legacy.********************.js 2.03 kB
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 1.97 kB
dotcom-rendering/dist/Liveness-importable.legacy.********************.js 6.8 kB
dotcom-rendering/dist/Liveness-importable.modern.********************.js 5.83 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.legacy.********************.js 3.08 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.25 kB
dotcom-rendering/dist/MostViewedFooterData-importable.legacy.********************.js 5.25 kB
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.99 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.legacy.********************.js 3.69 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 6.52 kB
dotcom-rendering/dist/newsletterEmbedIframe.legacy.********************.js 12.4 kB
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 12.4 kB
dotcom-rendering/dist/OnwardsUpper-importable.legacy.********************.js 7.84 kB
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 7.54 kB
dotcom-rendering/dist/ophan.legacy.********************.js 24.9 kB
dotcom-rendering/dist/ophan.modern.********************.js 24.1 kB
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.legacy.********************.js 291 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 284 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.legacy.********************.js 284 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 276 B
dotcom-rendering/dist/PulsingDot-importable.legacy.********************.js 2.31 kB
dotcom-rendering/dist/PulsingDot-importable.modern.********************.js 1.7 kB
dotcom-rendering/dist/QandaAtomWrapper-importable.legacy.********************.js 283 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 275 B
dotcom-rendering/dist/ReaderRevenueDev-importable.legacy.********************.js 4.64 kB
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 4.63 kB
dotcom-rendering/dist/readerRevenueDevUtils.js 2.67 kB
dotcom-rendering/dist/readerRevenueDevUtils.legacy.********************.js 3.97 kB
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 3.65 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.legacy.********************.js 2.35 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 2.27 kB
dotcom-rendering/dist/RecipeMultiplier-importable.legacy.********************.js 5.71 kB
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 4.59 kB
dotcom-rendering/dist/relativeTime.legacy.********************.js 12.5 kB
dotcom-rendering/dist/relativeTime.modern.********************.js 12.1 kB
dotcom-rendering/dist/RichLinkComponent-importable.legacy.********************.js 5.73 kB
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.7 kB
dotcom-rendering/dist/SecureSignupIframe-importable.legacy.********************.js 3.1 kB
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 2.8 kB
dotcom-rendering/dist/sentry.legacy.********************.js 791 B
dotcom-rendering/dist/sentry.modern.********************.js 789 B
dotcom-rendering/dist/sentryLoader.legacy.********************.js 38.1 kB
dotcom-rendering/dist/sentryLoader.modern.********************.js 33.9 kB
dotcom-rendering/dist/SetABTests-importable.legacy.********************.js 4.22 kB
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 4.02 kB
dotcom-rendering/dist/ShareCount-importable.legacy.********************.js 1.64 kB
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 1.62 kB
dotcom-rendering/dist/shimport.legacy.********************.js 9.53 kB
dotcom-rendering/dist/shimport.modern.********************.js 9.99 kB
dotcom-rendering/dist/ShowHideContainers-importable.legacy.********************.js 1.64 kB
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 1.07 kB
dotcom-rendering/dist/ShowMore-importable.legacy.********************.js 4.37 kB
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 4.26 kB
dotcom-rendering/dist/SignInGateMain.js 3.01 kB
dotcom-rendering/dist/SignInGateMain.legacy.********************.js 5.21 kB
dotcom-rendering/dist/SignInGateMain.modern.********************.js 4.92 kB
dotcom-rendering/dist/SignInGateSelector-importable.legacy.********************.js 4.41 kB
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 4.12 kB
dotcom-rendering/dist/SlotBodyEnd-importable.legacy.********************.js 3.03 kB
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 4.55 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.legacy.********************.js 3 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.17 kB
dotcom-rendering/dist/StickyBottomBanner-importable.legacy.********************.js 8.55 kB
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 9.58 kB
dotcom-rendering/dist/SubNav-importable.legacy.********************.js 3.63 kB
dotcom-rendering/dist/SubNav-importable.modern.********************.js 3.05 kB
dotcom-rendering/dist/SupportTheG-importable.legacy.********************.js 2.32 kB
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 2.24 kB
dotcom-rendering/dist/TimelineAtomWrapper-importable.legacy.********************.js 284 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 276 B
dotcom-rendering/dist/TopicFilterBank-importable.legacy.********************.js 1.76 kB
dotcom-rendering/dist/TopicFilterBank-importable.modern.********************.js 1.7 kB
dotcom-rendering/dist/TopRightAdSlot-importable.legacy.********************.js 1.98 kB
dotcom-rendering/dist/TopRightAdSlot-importable.modern.********************.js 1.98 kB
dotcom-rendering/dist/TweetBlockComponent-importable.legacy.********************.js 827 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 831 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.legacy.********************.js 5.85 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 4.76 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.legacy.********************.js 3.09 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.27 kB
dotcom-rendering/dist/VineBlockComponent-importable.legacy.********************.js 5.64 kB
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 4.53 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.legacy.********************.js 7.05 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 6.76 kB

compressed-size-action

@joecowton1 joecowton1 marked this pull request as ready for review November 30, 2022 17:18
@joecowton1 joecowton1 requested review from a team as code owners November 30, 2022 17:18
@joecowton1 joecowton1 linked an issue Nov 30, 2022 that may be closed by this pull request
Optimise chromatic workflows for CR and AR #6607
Closed
georgeblahblah
georgeblahblah reviewed Nov 30, 2022
View reviewed changes
Copy link
Contributor

@georgeblahblah georgeblahblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe! I had a suggestion about using actions/setup-node@v3 over guardian/actions-setup-node which is being deprecated. Interested to hear your thoughts!

.github/workflows/ar-chromatic.yml Show resolved Hide resolved
.github/workflows/cr-chromatic.yml Show resolved Hide resolved
@joecowton1 joecowton1 changed the title add new ar workflow Separate chromatic workflows Nov 30, 2022
sndrs
sndrs reviewed Dec 1, 2022
View reviewed changes
.github/workflows/ar-chromatic.yml Outdated Show resolved Hide resolved
.github/workflows/cr-chromatic.yml Outdated Show resolved Hide resolved
.github/workflows/dcr-chromatic.yml Outdated Show resolved Hide resolved
@joecowton1 joecowton1 merged commit eb9df30 into main Dec 2, 2022
@joecowton1 joecowton1 deleted the jc/apps-chromatic-workflow branch December 2, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

@jamesgorrie jamesgorrie Awaiting requested review from jamesgorrie

@georgeblahblah georgeblahblah Awaiting requested review from georgeblahblah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise chromatic workflows for CR and AR
3 participants
@joecowton1 @georgeblahblah @sndrs