Update DCR Dependencies (workspaces prep) #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.59 kB (0%) Total Size: 943 kB
ℹ️ View Unchanged
|
OllysCoding
changed the title
|
@OllysCoding we have published a new version of node-fetch ( |
|
@LinusU Cheers mate! |
OllysCoding
requested review from
DavidLawes,
jlieb10,
lucymonie,
nicl and
nitro-marky
as code owners
OllysCoding
changed the title
nitro-marky
approved these changes
Sep 22, 2021
lucymonie
reviewed
Sep 22, 2021
| @@ -86,7 +86,6 @@ const Headline: React.FC<{ | |||
| headlineText: string; | |||
| standfirst: string; | |||
| pillar: Theme; | |||
| starRating?: number; | |||
There was a problem hiding this comment.
What's the reason that star rating has been removed as part of this work?
There was a problem hiding this comment.
This prop was not used anywhere within the topMetaLiveblog component, after updating, ESLint identified it and threw an error as unused prop.
There was a problem hiding this comment.
(Despite it being passed in by a parent component, it isn't used within the component, making it redundant)
| @@ -97,7 +97,6 @@ export const ShowcaseInterview = () => ( | |||
| theme: Pillar.Culture, | |||
| }} | |||
| tags={[]} | |||
| isShowcase={true} | |||
There was a problem hiding this comment.
Just wondering why this is getting removed?
There was a problem hiding this comment.
While the data is passed into the component, the prop isn't actually consumed anywhere within it, meaning it's essentially redundant, causing ESLint to throw an error
lucymonie
approved these changes
Sep 22, 2021
marjisound
reviewed
Sep 22, 2021
There was a problem hiding this comment.
I noticed the following packages may need another update as they're not on their maximum semver version. Could you please have a look at them?
eslint-plugin-react
aws-sdk
@guardian/src-text-input
@guardian/src-text-area
@guardian/src-radio
@guardian/src-link
@guardian/src-icons
@guardian/src-foundations
@guardian/src-ed-lines
@guardian/src-button
…core due to unclear updates
marjisound
approved these changes
Sep 22, 2021
|
Thanks @marjisound, for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Update all DCR dependencies & dev dependencies in line with the allowances of the package.json.
Fixes related to package updates:
@ts-expect-errorfor new typescript errors which couldn't be resolvedWhy?
When we pull DCR & AR into yarn workspaces in the root of the monorepo, our lock files will be lost. By upgrading our packages to the most recent minor/patch versions available, when a new lock file is created, we'll have already fixed any associated bugs.