Update timeline at tablet/desktop #11396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
commented
May 9, 2024
domlander
force-pushed
the
doml/timeline-border-tablet-desktop
branch
from
a9defda
to
6ec8647
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +502 B (0%) Total Size: 793 kB ℹ️ View Unchanged
|
domlander
force-pushed
the
doml/timeline-border-tablet-desktop
branch
4 times, most recently
from
f81bbf0
to
a8569fd
Compare
domlander
force-pushed
the
doml/timeline-border-tablet-desktop
branch
from
a8569fd
to
078db88
Compare
mxdvl
approved these changes
May 9, 2024
Comment on lines
+43
to
+44
| border-left: 1px solid ${colour}; | ||
| border-right: 1px solid ${colour}; |
There was a problem hiding this comment.
Would the use of --timeline-event-border not be appropriate here? It brings about several benefits:
- no dynamic generation of Emotion styles
- consistency across all formats
It might require quite a bit more work we can address as a follow-up, as I appreciate the logic for overrides is a bit finnicky and this may not be the best PR to do this :D
|
Closing as I misinterpreted designs. We cannot remove the left and right border lines of the article as this would break the contract with the Standard Article design |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the timeline designs at tablet and desktop breakpoints:
Why?
Fixes: #11248
To match designs: https://www.figma.com/file/xPr2tZZger7pszcO075tAQ/New-Formats---April-23?type=design&node-id=4667-8581&mode=design&t=AA51JnDiAuLob1b3-0
Screenshots