Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not defer loading on Apps #11315

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Do not defer loading on Apps #11315

wants to merge 1 commit into from

Conversation

mxdvl
Copy link
Member

@mxdvl mxdvl commented Apr 30, 2024 •
edited

What does this change?

Remove the ability for Apps islands to be deferred.

Why?

There are typically less islands, and we want to experiment with loading them eagerly. We hope this improves responsiveness and native feel on Apps.

Follow-up on #11297

@mxdvl
feat(Island): do not defer loading on Apps
2a59996 
there are typically less islands,
and we want to experiment with loading them eagerly
@github-actions GitHub Actions
Copy link

Deploy build 34015 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link

Size Change: +157 B (0%)

Total Size: 785 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1093.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/1225.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/1293.client.web.********************.js 2.82 kB 0 B
dotcom-rendering/dist/1299.client.web.********************.js 926 B 0 B
dotcom-rendering/dist/1398.client.web.********************.js 4.83 kB 0 B
dotcom-rendering/dist/1499.client.web.********************.js 2.91 kB 0 B
dotcom-rendering/dist/2049.client.web.********************.js 2.95 kB 0 B
dotcom-rendering/dist/2342.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/2379.client.web.********************.js 5.41 kB 0 B
dotcom-rendering/dist/2471.client.web.********************.js 715 B 0 B
dotcom-rendering/dist/2499.client.web.********************.js 531 B 0 B
dotcom-rendering/dist/2680.client.web.********************.js 3.06 kB 0 B
dotcom-rendering/dist/269.client.web.********************.js 2.41 kB 0 B
dotcom-rendering/dist/2778.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/2834.client.web.********************.js 3.85 kB 0 B
dotcom-rendering/dist/2918.client.web.********************.js 3.48 kB 0 B
dotcom-rendering/dist/3000.client.web.********************.js 887 B 0 B
dotcom-rendering/dist/3055.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/3103.client.web.********************.js 3.42 kB 0 B
dotcom-rendering/dist/3114.client.web.********************.js 651 B 0 B
dotcom-rendering/dist/3118.client.web.********************.js 496 B 0 B
dotcom-rendering/dist/3255.client.web.********************.js 803 B 0 B
dotcom-rendering/dist/3292.client.web.********************.js 4.46 kB 0 B
dotcom-rendering/dist/3336.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/3340.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/3494.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/3584.client.web.********************.js 10.3 kB 0 B
dotcom-rendering/dist/3642.client.web.********************.js 787 B 0 B
dotcom-rendering/dist/3696.client.web.********************.js 5.79 kB +30 B (+1%)
dotcom-rendering/dist/3772.client.web.********************.js 440 B 0 B
dotcom-rendering/dist/3922.client.web.********************.js 724 B 0 B
dotcom-rendering/dist/3932.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/4123.client.web.********************.js 8.79 kB 0 B
dotcom-rendering/dist/417.client.web.********************.js 157 B 0 B
dotcom-rendering/dist/424.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/4442.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/4673.client.web.********************.js 723 B 0 B
dotcom-rendering/dist/4811.client.web.********************.js 994 B 0 B
dotcom-rendering/dist/4836.client.web.********************.js 3.59 kB 0 B
dotcom-rendering/dist/5044.client.web.********************.js 802 B 0 B
dotcom-rendering/dist/5084.client.web.********************.js 751 B 0 B
dotcom-rendering/dist/5096.client.web.********************.js 17.8 kB 0 B
dotcom-rendering/dist/5191.client.web.********************.js 22.4 kB 0 B
dotcom-rendering/dist/5308.client.web.********************.js 2.7 kB 0 B
dotcom-rendering/dist/5436.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/5490.client.web.********************.js 43.2 kB 0 B
dotcom-rendering/dist/565.client.web.********************.js 669 B 0 B
dotcom-rendering/dist/5698.client.web.********************.js 2.93 kB 0 B
dotcom-rendering/dist/5799.client.web.********************.js 3.8 kB 0 B
dotcom-rendering/dist/5817.client.web.********************.js 915 B 0 B
dotcom-rendering/dist/5875.client.web.********************.js 958 B 0 B
dotcom-rendering/dist/6057.client.web.********************.js 1.54 kB 0 B
dotcom-rendering/dist/6093.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/6167.client.web.********************.js 640 B 0 B
dotcom-rendering/dist/6198.client.web.********************.js 618 B 0 B
dotcom-rendering/dist/625.client.web.********************.js 12.3 kB 0 B
dotcom-rendering/dist/6506.client.web.********************.js 5.9 kB +32 B (+1%)
dotcom-rendering/dist/6640.client.web.********************.js 906 B 0 B
dotcom-rendering/dist/6857.client.web.********************.js 5.9 kB 0 B
dotcom-rendering/dist/705.client.web.********************.js 3.6 kB 0 B
dotcom-rendering/dist/7050.client.web.********************.js 4.63 kB 0 B
dotcom-rendering/dist/7052.client.web.********************.js 2.66 kB 0 B
dotcom-rendering/dist/7074.client.web.********************.js 3.59 kB 0 B
dotcom-rendering/dist/711.client.web.********************.js 6.41 kB 0 B
dotcom-rendering/dist/7116.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/7196.client.web.********************.js 889 B 0 B
dotcom-rendering/dist/72.client.web.********************.js 961 B 0 B
dotcom-rendering/dist/7239.client.web.********************.js 3.13 kB 0 B
dotcom-rendering/dist/7284.client.web.********************.js 5.84 kB 0 B
dotcom-rendering/dist/7387.client.web.********************.js 955 B 0 B
dotcom-rendering/dist/7713.client.web.********************.js 3.29 kB 0 B
dotcom-rendering/dist/7723.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/7808.client.web.********************.js 2.94 kB 0 B
dotcom-rendering/dist/8013.client.web.********************.js 2.81 kB 0 B
dotcom-rendering/dist/8101.client.web.********************.js 2.98 kB 0 B
dotcom-rendering/dist/8134.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/8179.client.web.********************.js 825 B 0 B
dotcom-rendering/dist/8385.client.web.********************.js 8.25 kB 0 B
dotcom-rendering/dist/8565.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/8791.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/8792.client.web.********************.js 4.77 kB 0 B
dotcom-rendering/dist/8824.client.web.********************.js 8.65 kB 0 B
dotcom-rendering/dist/889.client.web.********************.js 854 B 0 B
dotcom-rendering/dist/8907.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/8943.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/9060.client.web.********************.js 877 B 0 B
dotcom-rendering/dist/9162.client.web.********************.js 3.88 kB 0 B
dotcom-rendering/dist/9191.client.web.********************.js 2.66 kB 0 B
dotcom-rendering/dist/9225.client.web.********************.js 582 B 0 B
dotcom-rendering/dist/9325.client.web.********************.js 3.79 kB 0 B
dotcom-rendering/dist/9390.client.web.********************.js 3.61 kB 0 B
dotcom-rendering/dist/9396.client.web.********************.js 680 B 0 B
dotcom-rendering/dist/9397.client.web.********************.js 3.07 kB +29 B (+1%)
dotcom-rendering/dist/9430.client.web.********************.js 508 B 0 B
dotcom-rendering/dist/9507.client.web.********************.js 3.85 kB 0 B
dotcom-rendering/dist/9657.client.web.********************.js 1.85 kB 0 B
dotcom-rendering/dist/9741.client.web.********************.js 527 B 0 B
dotcom-rendering/dist/9789.client.web.********************.js 922 B 0 B
dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.77 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 424 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 3.52 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.62 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3.02 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.46 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.59 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.91 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.74 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 5.75 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 4.82 kB 0 B
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 6.76 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 5.64 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 538 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.26 kB 0 B
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 1.81 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 3.08 kB 0 B
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.6 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.56 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 4.11 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.43 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 3.79 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 613 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 842 B 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 344 B 0 B
dotcom-rendering/dist/frameworks.client.web.********************.js 20.7 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 4.38 kB +27 B (+1%)
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 10.9 kB +18 B (0%)
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 2.19 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.64 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 15.1 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 9.63 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 12.3 kB 0 B
dotcom-rendering/dist/index.client.web.********************.js 47.1 kB -9 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.65 kB 0 B
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 855 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.14 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.66 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 3.48 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.63 kB +30 B (+1%)
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.51 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 2.76 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 435 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.43 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 4.93 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 6.63 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.61 kB 0 B
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 5.75 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 8.33 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js 4.01 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 4.05 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 543 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 799 B 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 753 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 540 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 471 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.89 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js 4.64 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 1.99 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 6.75 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js 4.42 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.14 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 768 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.7 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 484 B 0 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 1.52 kB 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 648 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 6.98 kB 0 B
dotcom-rendering/dist/SignInGateCustomizableText.client.web.********************.js 957 B 0 B
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 1.19 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 2.69 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 3.73 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 4.15 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.45 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 3.86 kB 0 B
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 2.84 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 4.76 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 1.24 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.02 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.62 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.5 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 5.45 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 4.65 kB 0 B

compressed-size-action

@github-actions GitHub Actions
Copy link

Deploy build 9933 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dotcom-rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mxdvl