Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure published patterns satisfy AWS FSBP #2212

Closed
wants to merge 2 commits into from
Closed

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Feb 9, 2024

What does this change?

Use cdk-nag to ensure our patterns satisfy AWS Foundational Security Best Practices.

How to test

How can we measure success?

Have we considered potential risks?

Checklist

  • I have listed any breaking changes, along with a migration path 1
  • I have updated the documentation as required for the described changes 2

Footnotes

  1. Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs.

  2. If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid?

Copy link

changeset-bot bot commented Feb 9, 2024

⚠️ No Changeset found

Latest commit: 9c2f9c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@akash1810 akash1810 force-pushed the aa/cdk-nag branch 2 times, most recently from ee33aa3 to 84f8cc3 Compare February 9, 2024 19:55
@akash1810 akash1810 changed the title feat: Add cdk-nag feat: Ensure published patterns satisfy AWS FSBP Feb 9, 2024
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days

@github-actions github-actions bot added the Stale label Mar 18, 2024
@akash1810 akash1810 removed the Stale label Mar 18, 2024
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days

@github-actions github-actions bot added the Stale label Apr 18, 2024
Copy link
Contributor

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions bot closed this Apr 22, 2024
@akash1810 akash1810 reopened this Apr 22, 2024
@akash1810 akash1810 removed the Stale label Apr 22, 2024
@akash1810 akash1810 closed this May 17, 2024
@akash1810 akash1810 deleted the aa/cdk-nag branch May 17, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant