Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Play 3.0 #98

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Upgrade to Play 3.0 #98

merged 2 commits into from
Mar 12, 2024

Conversation

davidfurey
Copy link
Member

What does this change?

Minimal changes to upgrade to Play 3.0. This includes switching from Akka to Pekko.

How can we measure success?

I can upgrade atom-workshop to Play 3.0

Includes switch from Akka to Pekko
To avoid compiler warning
@davidfurey davidfurey requested a review from rtyley March 12, 2024 15:12
Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This will now need to be rolled out to:

You could use gha-scala-library-release-workflow to do a 'preview' release of this PR to Maven, and try that out in those repos before merging this PR, but it's probably not necessary!

See also:

@gu-scala-library-release
Copy link
Contributor

@davidfurey has published a preview version of this PR with release workflow run #13, based on commit ba68b55:

3.0.0-PREVIEW.play-30.2024-03-12T1559.ba68b556

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the play-3.0 branch, or use the GitHub CLI command:

gh workflow run release.yml --ref play-3.0

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@davidfurey
Copy link
Member Author

Thanks Roberto. I've published a preview version, and it works in atom-workshop.

@davidfurey davidfurey merged commit 8ccd409 into main Mar 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants