Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests under Java 17 (Upgrade to Play 2.9 & update Guice) #94

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix tests under Java 17 (Upgrade to Play 2.9 & update Guice) #94

merged 1 commit into from
Feb 14, 2024

Commits on Jan 18, 2024

  1. Fix tests under Java 17 (Guice upgrade via Play) 

    After #93 we found that
unfortunately the Release workflow failed while running the tests:

* The Release workflow uses Java 17 for all builds
* The Atom Maker library uses Play with Guice for Dependency Injection
* Guice gained Java 17 & 21 support with Guice v6:
  https://github.com/google/guice/wiki/Guice600
* Play only updated to Guice v6 (and gained general Java 17 support)
  with Play v2.9:
  playframework/playframework#11808
  playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
    @rtyley
    rtyley committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b4d55b3 View commit details
    Browse the repository at this point in the history