Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundler development dependency #85

Merged
merged 1 commit into from Apr 30, 2020
Merged

Commits on Apr 29, 2020

  1. Remove bundler development dependency

    We are currently in the [process](chef/chef-workstation#1123) of updating our package to use Ruby 2.7 which switched to using Bundler 2.x. We don't want to keep including bundler 1.x inside the package we generate so we have started going through and removing development dependencies on bundler.
    
    This works for us because all recent versions of Ruby include bundler (`gem install bundler` is unnecessary). `bundle install` in this directory still works. Our companies Ruby development has started removing bundler as a dev dependency to make the upgrade to Ruby 2.7 easier.
    
    Another option would be to remove the version specification, but that does cause a warning when doing `gem build`:
    ```
    $ gem build rb-fsevent.gemspec
    WARNING:  open-ended dependency on bundler (>= 0, development) is not recommended
      use a bounded requirement, such as '~> x.y'
    WARNING:  See http://guides.rubygems.org/specification-reference/ for help
    ```
    This is just a warning, but it is an annoying one.
    
    What would you think of either of these solutions?
    tyler-ball committed Apr 29, 2020
    Copy the full SHA
    4031e5b View commit details
    Browse the repository at this point in the history