BSD: Don't send ignored paths to kqueue #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 23, 2021
kqueue requires a file handle for every file and directory being watched so using Listen in a directory with .git or vendor/bundle quickly eats up all available file handles. Since these paths are being ignored by the silencer anyway, prevent watching these paths to conserve file handles.
jcs
force-pushed
the
bsd_ignore_silenced
branch
from
746ad79
to
eb952a2
Compare
|
@jcs Thank you for the PR. Can you please add tests? At least for these cases:
|
|
Hi @jcs Just checking in here to see if you can write those 3 tests? |
|
Hi @jcs Just checking in again to see if you can write those 3 tests? LMK if you need help with them. |
|
It appears so, thanks! |
|
Excellent! Thanks @jcs for looking into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this via Jekyll's
--watchoption and on OpenBSD I either have to get a CPU-eating poll of its giant directory structure (because of.gitandvendor/bundle) or I userb-kqueueand the process quickly dies after running out of file handles.Since the paths being ignored by the Silencer aren't used anyway, can it just not pass them to kqueue and avoid watching them?