Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont use experimental options for truffleruby #511

Merged
merged 1 commit into from Nov 7, 2020
Merged

Dont use experimental options for truffleruby #511

merged 1 commit into from Nov 7, 2020

Conversation

gogainda
Copy link
Contributor

@gogainda gogainda commented Nov 7, 2020

No description provided.

This was referenced Nov 7, 2020
Merged
Closed
@gogainda
Copy link
Contributor Author

gogainda commented Nov 7, 2020

@ColinDKelley pls review/merge

eregon
eregon approved these changes Nov 7, 2020
View reviewed changes
Copy link

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making the PR

@ColinDKelley
Copy link
Collaborator

Thanks @gogainda for making this PR for #507 !

@ColinDKelley ColinDKelley merged commit b32a035 into guard:master Nov 7, 2020
@ColinDKelley ColinDKelley linked an issue Nov 7, 2020 that may be closed by this pull request
unit tests failing sometimes on TruffleRuby #507
Closed
@ColinDKelley ColinDKelley mentioned this pull request Nov 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unit tests failing sometimes on TruffleRuby
3 participants
@gogainda @ColinDKelley @eregon