Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #504: try merging invoca .rubocop.yml #508

Merged
merged 29 commits into from Nov 27, 2020
Merged

Issue #504: try merging invoca .rubocop.yml #508

merged 29 commits into from Nov 27, 2020

Commits on Nov 23, 2020

  1. issue guard#504: bump robocop to v0.91.0 and update cop names to match

    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    2307dcf View commit details
    Browse the repository at this point in the history

  2. issue guard#504: try Invoca's .rubocop.yml; disable a few more cops t… 

    …hat don't fit well with code in this repo
    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    09b0b34 View commit details
    Browse the repository at this point in the history

  3. issue guard#504: rubocop -a

    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    89c7b77 View commit details
    Browse the repository at this point in the history

  4. issue guard#504: rubocop -A

    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    55c3929 View commit details
    Browse the repository at this point in the history

  5. issue guard#504: in .hound.yml, pin rubocop to v0.91.0

    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    9573077 View commit details
    Browse the repository at this point in the history

  6. issue guard#504: stub warn instead of puts

    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    ab870f5 View commit details
    Browse the repository at this point in the history

  7. issue guard#504: address many rubocop offenses

    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    870e8f0 View commit details
    Browse the repository at this point in the history

  8. issue guard#504: TargetRubyVersion: 2.7

    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    a6b6b5d View commit details
    Browse the repository at this point in the history

  9. issue guard#504: spell out exception; # rubocop:disable Lint/RescueEx… 

    …ception
    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    e9d888a View commit details
    Browse the repository at this point in the history

  10. issue guard#504: rubocop -a

    @ColinDKelley
    ColinDKelley committed Nov 23, 2020
    Copy the full SHA
    a871455 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. issue guard#504: merge in vendor/hound/config/style_guides/ruby.yml

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    f6f144e View commit details
    Browse the repository at this point in the history

  2. issue guard#504: move . back to previous line

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    395fdd5 View commit details
    Browse the repository at this point in the history

  3. issue guard#504: sort .rubocop.yml

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    e2b0066 View commit details
    Browse the repository at this point in the history

  4. issue guard#504: shorten change_fs

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    e422472 View commit details
    Browse the repository at this point in the history

  5. issue guard#504: drop some disabled cops; tune MethodLength to 15 wit… 

    …h a few disables
    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    cfacb88 View commit details
    Browse the repository at this point in the history

  6. issue guard#504: shorten long methods/disable MethodLength cop

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    2da3b5e View commit details
    Browse the repository at this point in the history

  7. issue guard#504: add method_defined?

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    12df4c4 View commit details
    Browse the repository at this point in the history

  8. issue guard#504: add inline rubocop:disable

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    7aa0320 View commit details
    Browse the repository at this point in the history

  9. issue guard#504: fix cop violations: respond_to_missing?; open

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    2645262 View commit details
    Browse the repository at this point in the history

  10. issue guard#504: add newer cops

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    5860ed7 View commit details
    Browse the repository at this point in the history

  11. issue guard#504: rubocop -a -A

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    46aa56a View commit details
    Browse the repository at this point in the history

  12. issue guard#504: fix keyword arg

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    5b6948b View commit details
    Browse the repository at this point in the history

  13. issue guard#504: rubocop:disable Lint/MissingSuper

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    cd980a7 View commit details
    Browse the repository at this point in the history

  14. issue guard#504: remove early returns and private attr_readers

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    c6fe53b View commit details
    Browse the repository at this point in the history

  15. issue guard#504: remove more early returns

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    ff8450d View commit details
    Browse the repository at this point in the history

  16. issue guard#504: fix stubbing to use @_remember_time_of_first_unproce… 

    …ssed_event
    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    b2fbfaf View commit details
    Browse the repository at this point in the history

  17. issue guard#504: fix *[] refactor bug

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    01cc75b View commit details
    Browse the repository at this point in the history

  18. issue guard#504: indent if from left; add parens

    @ColinDKelley
    ColinDKelley committed Nov 24, 2020
    Copy the full SHA
    745d0e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. issue guard#504: set Layout/EndAlignment: EnforcedStyleAlignWith: var… 

    …iable; move LineLength to Layout namespace
    @ColinDKelley
    ColinDKelley committed Nov 25, 2020
    Copy the full SHA
    e1045d2 View commit details
    Browse the repository at this point in the history