Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap Listener instances in WeakRef #477

Merged
merged 2 commits into from
Aug 23, 2020
Merged

Wrap Listener instances in WeakRef #477

merged 2 commits into from
Aug 23, 2020

Commits on Jul 21, 2020

  1. Wrap Listener instances in WeakRef 

    The `@listeners` variable holds a reference to each `Listener` instance
created by `Listen.to` and can only be cleared by calling `Listen.stop`.
This can prevent `Listener` instances from being garbage collected if
they are abandoned before `Listen.stop` is called.

This commit wraps `Listener` instances in `WeakRef` before adding them
to `@listeners`, to allow them to be garbage collected.

Partially addresses guard#476.
    @jonathanhefner
    jonathanhefner committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    ec274a1 View commit details
    Browse the repository at this point in the history

  2. Make Listen.to / Listen.stop thread-safe

    @jonathanhefner
    jonathanhefner committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    63eff89 View commit details
    Browse the repository at this point in the history