Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: jruby-9.2.0.0 #435

Closed
wants to merge 3 commits into from
Closed

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Sep 8, 2017

This PR updates the CI matrix to use latest JRuby.

Blog post: JRuby 9.2.0.0 released

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Sep 13, 2017

The build fails.

Ah, the issue is that ruby_dep does not support newer versions of Ruby.

In order to work around that, I began work on a PR there: e2/ruby_dep#35

@olleolleolle olleolleolle changed the title Travis: jruby-9.1.13.0 Travis: jruby-9.1.14.0 Nov 12, 2017
@junaruga
Copy link
Contributor

junaruga commented Jun 2, 2018

Now the latest JRuby version becomes 9.2.0.0.
http://jruby.org/

@olleolleolle
Copy link
Contributor Author

Thanks, @junaruga, I updated the PR to reflect that.

@olleolleolle olleolleolle changed the title Travis: jruby-9.1.14.0 Travis: jruby-9.2.0.0 Jun 3, 2018
@junaruga
Copy link
Contributor

junaruga commented Jun 3, 2018

@olleolleolle sorry this PR has error.

RubyDep Error: Unrecognized JRuby version: "9.2.0.0"

We might have to check a logic of ruby-dep, or "9.2.0.0" still does not exist in Travis?
https://rubygems.org/gems/ruby_dep/

Did you rebase to latest master branch?
This repo's tests are failed for only JRuby.
See https://travis-ci.org/guard/listen/builds/387076637

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Jun 4, 2018

@junaruga The ruby_dep project, which listen is using in its build, seems to have slowed down.

The logic in ruby_dep needs amending, to know about what MRI version "jruby-9.2.0.0" is equivalent to.

In order to support earlier JRuby versions, I offered a ruby_dep PR. No answer on that.

(I'll make a rebase this PR onto master. Update: Done.)

@rymai
Copy link
Member

rymai commented Jun 4, 2018

@olleolleolle @junaruga Thanks! Superseded by #446.

@rymai rymai closed this Jun 4, 2018
@olleolleolle olleolleolle deleted the patch-1 branch June 4, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants