Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pry #955

Closed
wants to merge 5 commits into from
Closed

fix pry #955

wants to merge 5 commits into from

Conversation

caseyprovost
Copy link

@caseyprovost caseyprovost commented Mar 21, 2020

On the latest version of Mac OS and ruby 2.6.5, pry appears to have the following error:

gems/ruby-2.6.5/gems/guard-2.16.1/lib/guard/jobs/pry_wrapper.rb:131:in `_setup': undefined method `file=' for #<Pry::History:0x00007faf61848420>

lib/guard/jobs/pry_wrapper.rb Outdated Show resolved Hide resolved
lib/guard/jobs/pry_wrapper.rb Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #955 into master will decrease coverage by 19.75%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #955       +/-   ##
===========================================
- Coverage   88.69%   68.94%   -19.76%     
===========================================
  Files          58       58               
  Lines        1991     1987        -4     
===========================================
- Hits         1766     1370      -396     
- Misses        225      617      +392     
Impacted Files Coverage Δ
lib/guard/jobs/pry_wrapper.rb 52.38% <66.66%> (-26.93%) ⬇️
lib/guard/dsl.rb 27.52% <0.00%> (-71.56%) ⬇️
lib/guard/commands/scope.rb 35.00% <0.00%> (-65.00%) ⬇️
lib/guard/watcher.rb 36.11% <0.00%> (-63.89%) ⬇️
lib/guard/commands/reload.rb 37.50% <0.00%> (-62.50%) ⬇️
lib/guard/internals/session.rb 35.95% <0.00%> (-57.31%) ⬇️
lib/guard/commands/pause.rb 50.00% <0.00%> (-50.00%) ⬇️
lib/guard/commands/notification.rb 50.00% <0.00%> (-50.00%) ⬇️
lib/guard/cli/environments/evaluate_only.rb 53.84% <0.00%> (-46.16%) ⬇️
lib/guard/deprecated/options.rb 42.85% <0.00%> (-44.24%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288a543...7d81307. Read the comment docs.

Copy link

@johnpaulashenfelter johnpaulashenfelter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caseyprovost I found the same problem and 👍 the PR (once you fix the whitespace ;)

@johnpaulashenfelter
Copy link

For those that care, the issue happens with the brand new release of pry, v0.13, which has a lot of changes, one of which is this one which seems to be undocumented.

For the time being, you can add

  gem 'pry', '< 0.13'

do you Gemfile assuming you're using this in a Rails app.

@rymai
Copy link
Member

rymai commented Mar 25, 2020

Closing in favor of #958.

@rymai rymai closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants