Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental fixes #853

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Experimental fixes #853

wants to merge 12 commits into from

Conversation

e2
Copy link
Contributor

@e2 e2 commented Aug 6, 2016 •
edited

Attempt to fix the Ctrl-c handling in Guard and reworked logging

Specifically:

  1. starting Guard, Ctrl-C to exit
  2. starting Guard, Ctrl-D to exit
  3. starting Guard, interrupting a task (e.g. RSpec)

Also, lots of interrupt-related message to help track down the sequence/causes of problems.

NOTES:

  • relies on patched Listen (see Gemfile)
  • relies on patched Guard::RSpec (see Gemfile)
  • relies on patched rb-inotify (see Gemfile)

@ioquatix
Copy link
Member

This looks interesting.

@ioquatix
Copy link
Member

I've contacted the author of rb-inotify and they said they would consider the fixes by mid-April.

@ioquatix ioquatix mentioned this pull request Mar 27, 2017
Merged
@ioquatix
Copy link
Member

@rymai is there interest in getting this working?

@ioquatix ioquatix mentioned this pull request Mar 27, 2017
Closed
@ioquatix
Copy link
Member

ioquatix commented Aug 19, 2017 •
edited

Looks like rails/thor#504 has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@e2 @ioquatix