forked from sveltejs/svelte
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make version export typed as string instead of the literal __VERSION__ #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.5.2...v6.5.3) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
--------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* feat: update dialog example * button always autofocusses, allows us to simplify --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
taken from sveltejs#7070
log which element is removed --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
…8186) Fixes one case of sveltejs#4765 --------- Co-authored-by: Ben Bucksch <bbucksch@jw.org> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
…tor" warning (sveltejs#8122) Fixes: sveltejs#8042 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
…js#7880) Related to sveltejs#5967. Closes sveltejs#7874 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
…eltejs#7254) * Move @html tutorial to end * move debug and html tag into one section * rename --------- Co-authored-by: Rémi Marche <35939574+Marr11317@users.noreply.github.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
Use button instead of non-interactive element (div). (Removes a Svelte a11y warning.)
- fast path for attribute quote marks common case - all regexes exclusively passed into read or match_regex which are only successful if matched at the beginning are altered so that the regex has this condition built in, preventing it from searching past the start index --------- Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
…eltejs#8299) fixes sveltejs#8296 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
fixes sveltejs#4233 by calling the callback after the iframe loads, which may be asynchronous --------- Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
…/> was the subject (sveltejs#8396)
…ng (sveltejs#8402) sveltejs#8167 introduced the strict version of it - until this is configurable, we should use the relaxed version instead, since many a11y docs actually advise using ul/ol etc
…ejs#8394) - split logic up into "is this a contenteditable element" and depending on the outcome use either .wholeText or .data to check if an update is necessary - add to puppeteer because jsdom does not support contenteditable - one test is skipped it because it fails right now but helps test sveltejs#5018 --------- Co-authored-by: suxin2017 <1107178482@qq.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
It is not possible to use typescript when using `target: document` during component initialization, because target can only be of type Element or ShadowRoot. This means that it is not possible to hydrate the entire document when managing the <html> element as a Svelte component. This commit fixes this by allowing documents to be targets.
Closes sveltejs#6969 As discussed there, container query support is quite useful to add to Svelte as it is now broadly available with Firefox releasing support imminently w/ FF v110 this upcoming week (~Feb 14th). Chrome has had support since ~Aug '22. The central issue is that css-tree which is a dependency for CSS AST parsing is significantly lagging behind on adding more recent features such as container query support. Ample time has been given to the maintainer to update css-tree and I do have every confidence that in time css-tree will receive a new major version with all sorts of modern CSS syntax supported including container queries. This PR provides an interim solution for what Svelte needs to support container queries now.
Fixes sveltejs#8417 The issue is that unpack_destructuring in each blocks, await blocks, and @const tags were making computed_props independently. This causes computed_props_# to conflict when each blocks were used with @const tags, or await blocks and @const tags, or consecutive @const tags together. Therefore, one solution is to use component.get_unique_name to, well, make unique names and never get conflicts.
Microdata are a strange set of attributes which are ONLY defined in markup, and have no relationship to the underlying Document Object Model node. As such programmatically defining an element and setting a property on it with a given Microdata attribute will not work: https://codepen.io/iambrosius/full/jOvXBBG One can read more about microdata here: https://developer.mozilla.org/en-US/docs/Web/HTML/Microdata The fix is to remove itemscope being a boolean attribute, because that opts into a transformation as a DOM property, which is wrong.
…ries and media query range syntax / MQ level 4 support. (sveltejs#8430)
fixes sveltejs#6752 --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Tan Li Hau <tanhauhau@users.noreply.github.com>
Implements ResizeObserver bindings: sveltejs#5524 (comment) Continuation of: sveltejs#5963 Related to sveltejs#7583 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
leftovers from sveltejs#8022
well that didn't work as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sveltejs/svelte:master