Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use GITHUB_OUTPUT envvar instead of set-output command #1265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arunsathiya
Copy link

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of set-output to $GITHUB_OUTPUT

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

sdroege
sdroege previously approved these changes Dec 31, 2023
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sdroege
Copy link
Member

sdroege commented Dec 31, 2023

Seems like something is broken on the Windows CI, which doesn't look like your fault though.

@pbor
Copy link
Contributor

pbor commented Dec 31, 2023

Actually it seems to me like the failure is caused by the patch :)

The Windows CI uses

    outputs:
      cachekey: ${{ steps.output.outputs.cachekey }}

to lookup the cached glib binaries. With this patch, that key is not present anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants