Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on github.com/ghodss/yaml #1385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lahabana
Copy link
Contributor

Description

Library is not maintained anymore and the same utility is provided in k8s which the project already depends on

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Remove dependency on github.com/ghodss/yaml which is not maintained anymore

Migration Guide

N/A

@denis256
Copy link
Member

pre-commit installed at .git/hooks/pre-commit
[INFO] Initializing environment for https://github.com/gruntwork-io/pre-commit.
goimports................................................................Failed
- hook id: goimports
- files were modified by this hook

modules/helm/template.go

Library is not supported anymore and the same utility
is provided in k8s which the project already depends on

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
Copy link
Contributor Author

lahabana commented Mar 8, 2024

@denis256 updated sorry it took so long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants