Add support for Azure Database for MySQL - Flexible Server #1245

supertrampr · 2023-02-10T22:36:37Z

Description

Fixes #1230.

Added new test cases in Terratest to support new Azure MySql Flexible Server resource.
Update Azure SDK for GO to the minimum version (v57.1.0) that starts to expose methods for managing new resources; the old Azure MySQL Single Server is still being maintained in newer version of the sdk.
Minor changes on documentation at /examples/azure/README.md.

TODOs

Read the Gruntwork contribution guidelines.

Update the docs.
Run the relevant tests successfully, including pre-commit checks.
Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added MySQL Flexible Server tests. [X]
Updated version of azure-sdk-go from 50.2.0 to 57.1.0. [X]

Migration Guide

…/azure/README.md.

denis256 · 2023-02-14T21:32:44Z

Tried to run tests, and noticed that fails TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example


=== RUN   TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z test_structure.go:130: Copied terraform folder /home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example to /tmp/terraform-azure-mysqldb-flexible-example2144364670/project/examples/azure/terraform-azure-mysqldb-flexible-example
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z retry.go:91: terraform [init -upgrade=false]
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: Running command terraform with args [init -upgrade=false]
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: There are some problems with the configuration, described below.
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: The Terraform configuration must be valid before initialization so that
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: Terraform can determine which modules and providers need to be installed.
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: ╷
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ Error: Invalid validation error message
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │   on variables.tf line 85, in variable "mysql_version":
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │   85:     error_message = "MySQL version for Flexbile Server instance should be 5.7 or 8.0.21"
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ The validation error message must be at least one full sentence starting
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ with an uppercase letter and ending with a period or question mark.
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ Your given message will be included as part of a larger Terraform error
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ message, written as English prose. For broadly-shared modules we suggest
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ using a similar writing style so that the overall result will be
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ consistent.
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: ╵
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; There are some problems with the configuration, described below.

supertrampr · 2023-02-17T22:35:29Z

Tried to run tests, and noticed that fails TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example


=== RUN   TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z test_structure.go:130: Copied terraform folder /home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example to /tmp/terraform-azure-mysqldb-flexible-example2144364670/project/examples/azure/terraform-azure-mysqldb-flexible-example
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z retry.go:91: terraform [init -upgrade=false]
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: Running command terraform with args [init -upgrade=false]
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: There are some problems with the configuration, described below.
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: The Terraform configuration must be valid before initialization so that
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: Terraform can determine which modules and providers need to be installed.
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: ╷
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ Error: Invalid validation error message
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │   on variables.tf line 85, in variable "mysql_version":
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │   85:     error_message = "MySQL version for Flexbile Server instance should be 5.7 or 8.0.21"
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ The validation error message must be at least one full sentence starting
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ with an uppercase letter and ending with a period or question mark.
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ Your given message will be included as part of a larger Terraform error
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ message, written as English prose. For broadly-shared modules we suggest
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ using a similar writing style so that the overall result will be
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: │ consistent.
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: ╵
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z logger.go:66: 
TestValidateAllTerraformModulesOnTerratest/home/circleci/project/examples/azure/terraform-azure-mysqldb-flexible-example 2023-02-14T21:17:44Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; There are some problems with the configuration, described below.

Sorry for the inconvenient! Should be fixed now.
Running on local environment test regarding Flexible Server are working fine, version of terraform is 1.3.9.
Let me know if something else comes up!

supertrampr · 2023-02-28T08:07:33Z

@denis256 Let me know if there is anything else that there is need to be done. Unfortunately I cannot trigger any circleci build

supertrampr · 2023-04-17T11:50:25Z

Hey @denis256 sorry to disturb you but I was wondering if this PR will be approved or needs further adjustment. Thanks!

supertrampr · 2023-07-25T07:36:52Z

Hi @denis256, any update on this?

denis256 · 2023-07-25T18:42:36Z

modules/azure/mysqlflexible.go

+	return &flexibleMySqlServer, nil
+}
+
+// GetMySqlFlexibleDBClientE is a helper function that will setup a MySql flexible DB client.


GetMySqlFlexibleServerDBClientE

denis256 · 2023-07-25T18:50:13Z

Hi, it is still not clear status of this PR:

title says [WIP]
there are conflicting files which prevent merging

Conflicting files
go.mod
go.sum

supertrampr · 2023-08-10T13:08:57Z

Hi, it is still not clear status of this PR:

title says [WIP]

there are conflicting files which prevent merging
Conflicting files
go.mod
go.sum

Hi @denis256, I have resolved merge conflicts.
I remove [WIP] from the title since tests are passing and no more updates from my side on my branch are needed.

supertrampr added 6 commits January 29, 2023 16:44

Update Terratest dependencies.

b73e4b3

Add Azure Database for MySql Flexible Server client services.

a09831c

Add helpers for MySql Flexible Server module and subsequent test.

8905638

Add test and example for MySql Flexible Server resource.

f5a69bd

Add example for resource mysql flexible server.

a27e10e

docs(azure-examples): Update version of azure-sdk-for-go in /examples…

e1c7220

…/azure/README.md.

supertrampr requested review from zackproser and denis256 as code owners February 10, 2023 22:36

supertrampr mentioned this pull request Feb 10, 2023

Add support for new Azure Database for MySQL - Flexible Server resource #1230

Open

fix(validation): Fix validation message for mysql_version variable.

aed20e9

denis256 reviewed Jul 25, 2023

View reviewed changes

Merge branch 'master' into feature/azurerm_mysql_flexible_server

391a74f

supertrampr changed the title ~~[WIP] Add support for Azure Database for MySQL - Flexible Server~~ Add support for Azure Database for MySQL - Flexible Server Aug 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Azure Database for MySQL - Flexible Server #1245

Add support for Azure Database for MySQL - Flexible Server #1245

supertrampr commented Feb 10, 2023 •

edited

denis256 commented Feb 14, 2023

supertrampr commented Feb 17, 2023

supertrampr commented Feb 28, 2023

supertrampr commented Apr 17, 2023

supertrampr commented Jul 25, 2023

denis256 Jul 25, 2023

denis256 commented Jul 25, 2023

supertrampr commented Aug 10, 2023

Add support for Azure Database for MySQL - Flexible Server #1245

Are you sure you want to change the base?

Add support for Azure Database for MySQL - Flexible Server #1245

Conversation

supertrampr commented Feb 10, 2023 • edited

Description

TODOs

Release Notes (draft)

Migration Guide

denis256 commented Feb 14, 2023

supertrampr commented Feb 17, 2023

supertrampr commented Feb 28, 2023

supertrampr commented Apr 17, 2023

supertrampr commented Jul 25, 2023

denis256 Jul 25, 2023

Choose a reason for hiding this comment

denis256 commented Jul 25, 2023

supertrampr commented Aug 10, 2023

supertrampr commented Feb 10, 2023 •

edited