Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scicoria/add eventhub mod #1225

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cicorias
Copy link

@cicorias cicorias commented Jan 8, 2023

Description

Fixes #000.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

if not marked as true tf was
erroring out
location of version for azurerm
now is in required_providers
in terraform block
during testing the pg test failed
to cleanup properly even though
the postgres instance
was the only thing in the group

thiis will ensure a rg delete
will kill the rg and all children resources
at test end
ssh keys are used for azure and
should not be committed

log files used for local runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant