Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(version-checker): allow override version arg and regex #1182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

khuedoan
Copy link

@khuedoan khuedoan commented Sep 21, 2022

Description

Allow override the version argument in version checker because some commands doesn't have the --version flag, for example:

$ helm --version
Error: unknown flag: --version

$ helm version
version.BuildInfo{Version:"v3.9.4", GitCommit:"v3.9.4", GitTreeState:"", GoVersion:"go1.18.5"}

This PR also includes a similar change to allow override version regex matcher.

This is tested on my personal project in khuedoan/homelab@4f80b87

(There's no related Issue)

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added version-checker options to change the default argument and regex matcher

Migration Guide

This change is backward compatible.

@khuedoan khuedoan changed the title feat(version-checker): allow override version arg and regex [WIP] feat(version-checker): allow override version arg and regex Sep 21, 2022
@khuedoan khuedoan changed the title [WIP] feat(version-checker): allow override version arg and regex feat(version-checker): allow override version arg and regex Sep 21, 2022
@khuedoan khuedoan marked this pull request as ready for review September 21, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant