fix: Implement proper checking of ClusterIPs health #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deedubs
requested review from
marinalimeira,
infraredgirl,
robmorgan and
ina-stoyanova
as code owners
denis256
approved these changes
Apr 20, 2022
| case corev1.ServiceTypeLoadBalancer: | ||
| ingress := service.Status.LoadBalancer.Ingress | ||
| // The load balancer is ready if it has at least one ingress point | ||
| return len(ingress) > 0 | ||
| // type: ClusterIP is available when the Pods matched by the Service selector are in the Status == Ready | ||
| case corev1.ServiceTypeClusterIP: |
There was a problem hiding this comment.
Make sense to handle NodePort services too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed several tests we were attempting to write were failing with a race condition on Pod availability. This PR adds proper checking of a ClusterIPs endpoints for the status managed by the pod controller via possible readiness probes.