Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to make certain assertions #18

Merged
merged 2 commits into from
Nov 28, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 27 additions & 0 deletions entrypoint/assertions.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package entrypoint

import (
"fmt"
"github.com/urfave/cli"
"os"
)

// StringFlagRequiredE checks if a required string flag is passed in on the CLI. This will return the set string, or an
// error if the flag is not passed in.
func StringFlagRequiredE(cliContext *cli.Context, flagName string) (string, error) {
value := cliContext.String(flagName)
if value == "" {
return "", fmt.Errorf("--%s is required", flagName)
}
return value, nil
}

// EnvironmentVarRequiredE checks if a required environment variable is set. This will return the environment variable
// value, or an error if the environment variable is not set.
func EnvironmentVarRequiredE(varName string) (string, error) {
value := os.Getenv(varName)
if value == "" {
return "", fmt.Errorf("The environment variable %s is required to be set", varName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a custom type of errors. It makes it easier to check for errors and write tests against them.

}
return value, nil
}
60 changes: 60 additions & 0 deletions entrypoint/assertions_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
package entrypoint

import (
"os"
"testing"

"github.com/stretchr/testify/assert"
"github.com/urfave/cli"
)

func TestStringFlagRequiredOnMissingFlag(t *testing.T) {
t.Parallel()

app := createSampleAppWithRequiredFlag()
app.Action = func(cliContext *cli.Context) error {
value, err := StringFlagRequiredE(cliContext, "the-answer-to-all-problems")
assert.NotNil(t, err)
assert.Equal(t, value, "")
return nil
}
args := []string{"app"}
app.Run(args)
}

func TestStringFlagRequiredOnSetFlag(t *testing.T) {
t.Parallel()

app := createSampleAppWithRequiredFlag()
app.Action = func(cliContext *cli.Context) error {
value, err := StringFlagRequiredE(cliContext, "the-answer-to-all-problems")
assert.Nil(t, err)
assert.Equal(t, value, "42")
return nil
}
args := []string{"app", "--the-answer-to-all-problems", "42"}
app.Run(args)
}

func TestEnvironmentVarRequiredOnMissingEnvVar(t *testing.T) {
value, err := EnvironmentVarRequiredE("THE_ANSWER_TO_ALL_PROBLEMS")
assert.NotNil(t, err)
assert.Equal(t, value, "")
}

func TestEnvironmentVarRequiredOnSetEnvVar(t *testing.T) {
os.Setenv("THE_ANSWER_TO_ALL_PROBLEMS", "42")
value, err := EnvironmentVarRequiredE("THE_ANSWER_TO_ALL_PROBLEMS")
assert.Nil(t, err)
assert.Equal(t, value, "42")
}

func createSampleAppWithRequiredFlag() *cli.App {
app := cli.NewApp()
app.Flags = []cli.Flag{
cli.StringFlag{
Name: "the-answer-to-all-problems",
},
}
return app
}