Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping sprig to v3.2.3 to fix kebabcase bug #162

Merged
merged 2 commits into from Feb 13, 2024

Conversation

yhakbar
Copy link
Contributor

@yhakbar yhakbar commented Feb 13, 2024

Description

Fixes #155.

Bumps sprig to v3.2.3 to fix kebabcase bug, as the release addresses the double dash that can occur when numbers and letters are combined together in kebabcase usage.

See: Masterminds/sprig#348

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated sprig to v3.2.3. Fixes bug with kebabcase introducing an extra dash.

@yhakbar yhakbar marked this pull request as draft February 13, 2024 20:55
@yhakbar yhakbar marked this pull request as ready for review February 13, 2024 21:04
@yhakbar yhakbar merged commit 05de8b3 into master Feb 13, 2024
3 checks passed
@yhakbar yhakbar deleted the 155/fix/fixing-how-kebabcase-is-handled branch February 13, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kebabcase doesn't work right when the variable value contains a number followed by a letter
2 participants