Remove coffeescript from dependencies. #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
To ease transition, if the coffeescript package is still around, Grunt will attempt to load it. If it is not, and the user loads a CoffeeScript file, Grunt will print a useful error indicating that the coffeescript package should be installed as a dev dependency.
STRML
force-pushed
the
remove-coffeescript
branch
from
a859006
to
ba492b6
Compare
daniellockyer
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jul 21, 2020
refs gruntjs/grunt#1675 - Grunt 1.2.0 removed coffeescript as a dependency, opting to leave it to the users to install - we use `grunt-bg-shell`, which is built in coffeescript and therefore needs the dependency else `grunt dev` doesn't work - I don't like needing to add coffeescript but it'll do until we give the dev experience a good cleanup
This was referenced May 25, 2021
This was referenced Jun 6, 2021
1 task
Open
1 task
1 task
This was referenced Jan 19, 2024
1 task
1 task
1 task
1 task
Open
1 task
This was referenced Feb 24, 2024
This was referenced Mar 2, 2024
This was referenced Mar 21, 2024
Open
1 task
1 task
This was referenced Apr 14, 2024
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gruntjs/grunt-cli#117 removes the need for coffeescript in grunt by using Liftoff instead.
To ease transition, if
coffeescriptis still around, Grunt will attempt to load it. If it is not, and the user loads a CoffeeScript file, Grunt will print a useful error indicating that thecoffeescriptpackage should be installed as a dev dependency.This is considerably more user-friendly than dropping the
requireentirely, but doing so is feasible with the latestgrunt-clias users may simply usegrunt --require coffeescript/register.