Update logging to be less verbose #454
Conversation
|
@vladikoff the failing tests are already existing failures. taking a look at fixing them for a separate commit. |
|
@eddiemonge: please fetch and rebase. |
|
@XhmikosR updated |
| test.expect(2); | ||
| var cwd = path.resolve(fixtures, 'patterns'); | ||
| var assertWatch = helper.assertTask('watch', {cwd: cwd}); | ||
| var assertWatch = helper.assertTask('watch', {cwd:cwd, verbose:true}); |
There was a problem hiding this comment.
The spaces after ":" are needed.
There was a problem hiding this comment.
oh sorry, I thought your changes removed them.
There was a problem hiding this comment.
It's actually the grunt preset in JSCS that requires them.
Instead of showing all the files that have changed, state how many have changed (per change type) unless verbose is passed. Then display all the changes.
|
updated again |
|
I'm not sure I'm completely 100% with this. I mean, I see there are some cases it might make sense but if it's a couple of files passing verbose might be too much. /CC @vladikoff for feedback. |
|
verbose should be just that, verbose. non-verbose should be concise. In the attached example, other tasks do minimal output by default. This one doesn't; its excessively noisy
|
|
Like I said I see the use case for this. It's just that we shouldn't overdo it like with other contrib plug-ins Anyway just wait for others to chime in.
|
I agree which is why I send pull requests to those to show something by default and more when asked. Just because something else is broken shouldn't mean don't fix something else. |
|
You may also want to take a look at #467. It doesn't change any defaults and is merely an opt-in feature. The previous output can always be shown when run with Personally I like to see no output at all (when no errors occur), because usually what I care about are the tasks triggered. |
|
closing as this is over 3 years old and unlikely to land even though it would be nice to have |
Instead of showing all the files that have changed, state how many have
changed (per change type) unless verbose is passed. Then display all the
changes.