-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Azure Storage support #158
base: main
Are you sure you want to change the base?
WIP: Add Azure Storage support #158
Conversation
@@ -5,9 +5,8 @@ resource "azurerm_resource_group" "default" { | |||
} | |||
|
|||
module "networking" { | |||
depends_on = [azurerm_resource_group.default] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a depends_on
here, implicit dependency should suffice
@@ -24,12 +23,18 @@ module "networking" { | |||
// } | |||
|
|||
module "compute" { | |||
source = "./compute" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting
Thanks for the contribution @rudolphjacksonm, I didn't have much time to review the PR, but keep up the good work. I'll review asap, probably tomorrow or at maximum Wednesday (even at WIP status, just so you can get a heads-up on wether it'll be easily merged or if I have any considerations). |
No description provided.