[export] [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log #36621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
added
exported
release notes: no
copybara-service
bot
force-pushed
the
test_633802446
branch
2 times, most recently
from
61492e4
to
4d809e1
Compare
copybara-service
bot
force-pushed
the
test_633802446
branch
3 times, most recently
from
ae7c37f
to
07c388e
Compare
grpc-checks
bot
added
per-call-memory/increase
per-channel-memory/neutral
per-call-memory/neutral
and removed
per-call-memory/increase
labels
copybara-service
bot
force-pushed
the
test_633802446
branch
2 times, most recently
from
5991edc
to
ed4f783
Compare
copybara-service
bot
force-pushed
the
test_633802446
branch
5 times, most recently
from
56f3cc0
to
333d6b0
Compare
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future. We have the following mapping 1. gpr_log(GPR_INFO,...) -> LOG(INFO) 2. gpr_log(GPR_ERROR,...) -> LOG(ERROR) 3. gpr_log(GPR_DEBUG,...) -> VLOG(2) Reviewers need to check : 1. If the above mapping is correct. 2. The content of the log is as before. gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected. PiperOrigin-RevId: 634278682
copybara-service
bot
force-pushed
the
test_633802446
branch
from
333d6b0
to
bb201db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[export] [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.
We have the following mapping
Reviewers need to check :
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.
DO NOT SUBMIT. This PR is for testing purposes only. cl/633802446