Fix msbuild failing when '@' is present in path (2nd attempt) #31527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was ambiguity in references to Source metadata on some Items. These are now qualified to remove the ambiguity.
This reverts commit bb5d5dd.
|
@jtattermusch new fix for #30746 which should also fix the distribution tests. |
jtattermusch
added
the
release notes: yes
jtattermusch
approved these changes
Nov 7, 2022
| <!-- Adding Distinct() is just a precaution as the CSC compiler complains if there are | ||
| duplicate source files | ||
| --> | ||
| <Compile Include="@(_Protobuf_CodeCompile->Distinct())" /> |
There was a problem hiding this comment.
qq: if there are duplicates, wouldn't it be fair to report that as a problem? Did this actually happen to you during testing?
There was a problem hiding this comment.
The Distinct() is just a precaution. No duplicates seen in testing with the new Unescape() fix (duplicates were seen with the old qualified Source fix).
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #30746 - "C# Protobuf msbuild task fails with glob pattern if "@" is present in the path"
After investigating there is a feature/bug with MSBuild: dotnet/msbuild#8104
where setting the
Sourcemetadata from theIdentitymetadata needs unescaping if the original items come froma wildcard match and the paths contain an '@' character. See dotnet/msbuild#8104 (comment) for details.
Also as a precaution make sure no duplicate files in the list of files passed to the CSC compiler.
Tested on Linux and Windows with MSBuild versions 15, 16 and 17