c-ares DNS resolver: remove unnecessary code in SRV callback #31426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call to
grpc_ares_notify_on_event_locked
from the SRV callback is unnecessary:There are only a few places that
on_srv_query_done_locked
callback can be invoked from, and we already callnotify_on_event_locked
(updating polled file descriptors) after each of them:Furthermore, this call to
grpc_ares_notify_on_event_locked
from the SRV callback was buggy, because in certain cases it could destroy the fd that generated theon_readable_locked
callback it's being invoked from, which could then cause a use-after-free in here. So it looks like the direct cause of b/243676671.