Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outlier detection: remove env var protection #31251

Merged
merged 2 commits into from Oct 6, 2022
Merged

outlier detection: remove env var protection #31251

merged 2 commits into from Oct 6, 2022

Conversation

markdroth
Copy link
Member

@markdroth markdroth commented Oct 5, 2022 •
edited

Enable outlier detection functionality by default, as described in gRFC A50.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Oct 5, 2022
@markdroth markdroth requested a review from yashykt October 5, 2022 19:00
yashykt
yashykt approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@yashykt yashykt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes yes probably?

@markdroth markdroth added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Oct 6, 2022
@markdroth markdroth merged commit 11fbb63 into grpc:master Oct 6, 2022
@markdroth markdroth deleted the xds_outlier_detection_remove_env_var branch October 6, 2022 18:26
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 6, 2022
@markdroth markdroth mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashykt yashykt yashykt approved these changes

Assignees
No one assigned
Labels
bloat/improvement imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markdroth @yashykt