Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the domain-socket client address read out from the ServerContext #31108

Merged
merged 1 commit into from Oct 19, 2022

Conversation

nickylba
Copy link
Contributor

Fixes #30581

When client is a unix-domain client, this PR can fix the address in ServerContext.peer().

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 23, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@yashykt yashykt added release notes: yes Indicates if PR needs to be in release notes kokoro:run labels Oct 18, 2022
@drfloob drfloob merged commit 447bd66 into grpc:master Oct 19, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 19, 2022
fnadeau added a commit to fnadeau/grpc that referenced this pull request Dec 21, 2022
For UNIX sockets, code has been fixed but comment and log were not.
eugeneo pushed a commit that referenced this pull request Jan 3, 2023
For UNIX sockets, code has been fixed but comment and log were not.
wanlin31 pushed a commit that referenced this pull request May 18, 2023
For UNIX sockets, code has been fixed but comment and log were not.
townsend2010 added a commit to canonical/grpc that referenced this pull request Jul 7, 2023
townsend2010 added a commit to canonical/grpc that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should use getpeername instead of getsockname for unix domain client address
4 participants