Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby windows ucrt build #31051

Merged
merged 1 commit into from Sep 19, 2022
Merged

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Sep 19, 2022

We were previously trying to define this macro through an env var, which actually only affects the make invocation that extconf.rb uses to build the grpc core library on non-windows platforms.

Note that all of the other CPPFLAGS set through env vars are targeting the grpc core library, rather than the ruby C-extension code, so it worked. But this new macro for windows ucrt is targeting the ruby C-extension code, so it looks like it needs to be set via $CFLAGS.

Should fix #30933

cc @johnnyshields

@apolcyn
Copy link
Contributor Author

apolcyn commented Sep 19, 2022

artifact macos failure unrelated

@apolcyn apolcyn merged commit d2b4f23 into grpc:master Sep 19, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 20, 2022
@johnnyshields
Copy link
Contributor

@apolcyn FYI I've confirm this fix works. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported Specifies if the PR has been imported to the internal repository lang/ruby release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 1.49.0.pre1 - grpc getting gRPC dynamic C core load error on x64-mingw-ucrt
3 participants