New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tls] Remove support for pthread tls #31040
Conversation
@dennycd I'm having a heck of a time sorting out ios deployment versions in this PR so I'll probably ask for some help with that piece assuming we can move forward with this. |
Updating w/ deployment target change removed. TLS was introduced by Apple from XCode 8.x and up |
54419d5
to
8655419
Compare
8655419
to
5247f83
Compare
d90f8e4
to
065b6b2
Compare
b6b6b58
to
bbf217e
Compare
bbf217e
to
dfe9da9
Compare
objc/iOS tests now all pass, a few summary notes below
The discrepancy from # 2 likely come from running on MacOS Mojave node with older Xcode toolchain (XCode 11.3) which may not yet fully support TLS on all device targets. Would recommend we upgrade grpc_basictests_cpp_ios to MacOS Monterey node in order to remove this configuration discrepancy (cl/475944915). ; ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS/ObjC part of this PR lgtm.
Alternative to #31030, #31036
It's looking likely that our pthread TLS implementation is no longer necessary.
@dennycd is going to confirm.
Assuming that's the case, let's finally delete this gunk.