Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the TODO item in build target grpc_base -- part error #31002

Closed
wants to merge 2 commits into from
Closed

Clean up the TODO item in build target grpc_base -- part error #31002

wants to merge 2 commits into from

Conversation

ralphchung
Copy link
Contributor

This PR requires cherry picking before merging.

This PR fixes the TODO item in the error part of build target grpc_base.

@ralphchung ralphchung added the release notes: no Indicates if PR should not be in release notes label Sep 15, 2022
@ralphchung
Copy link
Contributor Author

Closing this PR since #31521 should cover the same thing.

@ralphchung ralphchung closed this Nov 2, 2022
@ralphchung ralphchung deleted the fix-build-grpc-base-todo-error branch November 2, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bloat/none lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ralphchung