Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing php 8.2 deprecations #30997

Merged
merged 5 commits into from Oct 26, 2022
Merged

fixing php 8.2 deprecations #30997

merged 5 commits into from Oct 26, 2022

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Sep 15, 2022

PHP 8.2 RC's are out, and grpc complains that Creation of dynamic property Grpc\Call::$channel is deprecated.
Adding a property for channel resolves this, and I also fixed a bunch of deprecations and minor issues in the tests themselves.

fixes various dynamic property deprecations in the tests themselves
at() matcher is deprecated, to be removed in phpunit 10. switch to withConsecutive
this resolves "Creation of dynamic property Grpc\Call::$channel is deprecated" in php 8.2
@brettmc
Copy link
Contributor Author

brettmc commented Sep 15, 2022

@stanley-cheung I think you're the right person to review this PR for me.

implicit casting from float to int is deprecated from 8.1, so users would receive a deprecation warning if trying to do this
@stanley-cheung stanley-cheung self-assigned this Oct 13, 2022
@stanley-cheung stanley-cheung added kokoro:run release notes: yes Indicates if PR needs to be in release notes labels Oct 13, 2022
@stanley-cheung
Copy link
Contributor

Sorry for the delay. Wasn't aware of this until just now. Will look into this. Thanks for helping fix this.

@stanley-cheung
Copy link
Contributor

@brettmc Can I confirm that, once this PR is patched in, src/php/bin/build_all_docker_images.sh and src/php/bin/run_all_docker_images.sh run to completions with no errors?

@brettmc
Copy link
Contributor Author

brettmc commented Oct 17, 2022

@stanley-cheung - confirming that both src/php/bin/build_all_docker_images.sh and src/php/bin/run_all_docker_images.sh run to completion for me with this patch.

Copy link
Contributor

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contributions!

@stanley-cheung stanley-cheung merged commit 14d1403 into grpc:master Oct 26, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 26, 2022
@brettmc brettmc deleted the php82 branch November 7, 2022 02:55
@gsdaemon
Copy link

2a6cf72
this was not merged unfortunately and it still shows deprecation notices in php 8.2
Notice (8192): Creation of dynamic property Grpc\Call::$channel is deprecated in grpc/src/lib/AbstractCall.php on line 60

@brettmc
Copy link
Contributor Author

brettmc commented Mar 21, 2023

Hi @gsdaemon
This was released in v1.51.0: https://github.com/grpc/grpc/blob/v1.51.0/src/php/ext/grpc/call.c#L627 and is also in the most recently released version: https://github.com/grpc/grpc/blob/v1.52.1/src/php/ext/grpc/call.c#L627
Can you confirm the extension version you're using?
It looks like pecl by default is installing an earlier version (I get 1.47.4), so you could try to install an explicit version of 1.51+.
That said, it looks like 1.51+ has a bug that you don't want (I can't run my tests to confirm that the notice has gone away on any version of grpc that has the fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported Specifies if the PR has been imported to the internal repository lang/php release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants