New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing php 8.2 deprecations #30997
fixing php 8.2 deprecations #30997
Conversation
fixes various dynamic property deprecations in the tests themselves
at() matcher is deprecated, to be removed in phpunit 10. switch to withConsecutive
this resolves "Creation of dynamic property Grpc\Call::$channel is deprecated" in php 8.2
@stanley-cheung I think you're the right person to review this PR for me. |
implicit casting from float to int is deprecated from 8.1, so users would receive a deprecation warning if trying to do this
Sorry for the delay. Wasn't aware of this until just now. Will look into this. Thanks for helping fix this. |
@brettmc Can I confirm that, once this PR is patched in, |
@stanley-cheung - confirming that both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contributions!
2a6cf72 |
Hi @gsdaemon |
PHP 8.2 RC's are out, and grpc complains that
Creation of dynamic property Grpc\Call::$channel is deprecated
.Adding a property for
channel
resolves this, and I also fixed a bunch of deprecations and minor issues in the tests themselves.