Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gpr_codegen #30899

Merged
merged 7 commits into from Sep 13, 2022
Merged

Remove gpr_codegen #30899

merged 7 commits into from Sep 13, 2022

Conversation

ralphchung
Copy link
Contributor

@ralphchung ralphchung commented Sep 8, 2022 •
edited

This PR requires cherry picking before merging.

In #30518, build target gpr_codegen has been merged to gpr. We no longer need this.

@ralphchung ralphchung added the release notes: no Indicates if PR should not be in release notes label Sep 8, 2022
@ralphchung ralphchung marked this pull request as ready for review September 8, 2022 21:59
@ctiller
Copy link
Member

ctiller commented Sep 9, 2022

Will need to cherry-pick in - there's a fair amount of usage internally

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 9, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@ctiller ctiller added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Sep 12, 2022
ctiller
ctiller approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@ctiller ctiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - flipped the release notes bit since this was once a public target we should probably note its removal at least

@ralphchung ralphchung merged commit 3b66ddb into grpc:master Sep 13, 2022
@ralphchung ralphchung deleted the remove-gpr-codegen branch September 13, 2022 17:11
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vignesh2208 Vignesh2208 Vignesh2208 approved these changes

@ctiller ctiller ctiller approved these changes

Assignees
No one assigned
Labels
bloat/none disposition/Needs Internal Changes imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ralphchung @ctiller @Vignesh2208