Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.11 #30818

Merged
merged 11 commits into from Sep 12, 2022
Merged

Support Python 3.11 #30818

merged 11 commits into from Sep 12, 2022

Conversation

gnossen
Copy link
Contributor

@gnossen gnossen commented Sep 1, 2022 •
edited

  • Git made breaking change related to file ownership, so this had to be silenced.
  • There were a couple of places where 3.6 was still referenced. Those have been removed.

@gnossen gnossen added priority/P0/RELEASE BLOCKER release notes: yes Indicates if PR needs to be in release notes labels Sep 9, 2022
@gnossen gnossen mentioned this pull request Sep 9, 2022
Closed
@gnossen gnossen marked this pull request as ready for review September 9, 2022 21:57
@gnossen
Copy link
Contributor Author

gnossen commented Sep 9, 2022

CC @XuanWang-Amos

@gnossen gnossen enabled auto-merge (squash) September 12, 2022 18:03
sergiitk
sergiitk approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking questions/suggestions.

tools/dockerfile/grpc_artifact_python_manylinux2014_x86/Dockerfile Show resolved Hide resolved
tools/dockerfile/grpc_artifact_python_musllinux_1_1_x64/Dockerfile
@@ -35,3 +36,5 @@ RUN curl -sSL -o ccache.tar.gz https://github.com/ccache/ccache/releases/downloa
&& make -j4 && make install \
&& cd ../.. \
&& rm -rf ccache-4.5.1 ccache.tar.gz

RUN git config --global --add safe.directory /var/local/jenkins/grpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know it's /var/local/jenkins/grpc? Is this $HOME? Should we then use the env var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not home. As far as I know, there is no env var provided for this. It's simply hardcoded in the docker images. We could set an env var in run_tests.py, but I think that refactor is out of the scope of this PR.

@gnossen gnossen merged commit 2297249 into grpc:master Sep 12, 2022
gnossen added a commit to gnossen/grpc that referenced this pull request Sep 12, 2022
@gnossen
Support Python 3.11 (grpc#30818)
22b00a5 
* Support Python 3.11

* Update build images for 3.11

* Whoopsie

* The architecture of this thing is garbage

* Silence ownership warning

* Account for change in git behavior

* Fix directory

* I am in great pain

* Update Windows and arm linux

* Agh

* Clean up
@gnossen gnossen mentioned this pull request Sep 12, 2022
Merged
gnossen added a commit that referenced this pull request Sep 12, 2022
@gnossen
Support Python 3.11 (#30818) (#30944)
b3c764c 
* Support Python 3.11

* Update build images for 3.11

* Whoopsie

* The architecture of this thing is garbage

* Silence ownership warning

* Account for change in git behavior

* Fix directory

* I am in great pain

* Update Windows and arm linux

* Agh

* Clean up
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 12, 2022
veblush added a commit that referenced this pull request Sep 20, 2022
@veblush @apolcyn
@drfloob @gnossen @sergiitk @markdroth
Upmerge changes from 1.49.x (#31068)
fa65716 
* Bump 1.49.x branch to 1.49.0.pre1 (#30615)

* bump version to 1.49.0-pre1

* regenerate projects

* [backport][v1.49.x] forkable fixes (#30646)

* Fix forkable globals (#30608)

* Fix forkable repeated registration (#30642)

This fixes a bug that could occur on repeated grpc initialization (after a complete shutdown)

Fixes #30640

* Drop support for ruby 2.5 (#30699) (#30762)

* Drop ruby 2.5 support

* Backport: "stabilize the C2P resolver URI scheme" to v1.49.x (#30654)

* stabilize the C2P resolver URI scheme

* Bump 1.49 branch to 1.49.0.pre2 (#30786)

* bump version to 1.49.0-pre2

* regenerate projects

* Update protobuf on ancillary packages (#30795) (#30805)

* Bump release version on 1.49 to 1.49.0.pre3 (#30814)

* bump version to 1.49.0-pre3

* regenerate projects

* xDS interop: enable pod log collection in the buildscripts (#30735) (#30856)

- Enables pod log collection in all PSM interop jobs implemented in #30594.
- Associate test suite runs with their own log file, so it's displayed on "Target Log" tab

* xDS interop: buildscripts: fix run_test return status (#30768) (#30875)

To capture the return status of the test in run_test the last command must be the call to the test itself.
This removes `set +x`, which makes the run_test always return success, and not propagate the test status.

I can't find it, but this exact error bit us before. Looks like it leaked to other scripts.
The good thing is if the test was executed, it's failure would still be picked up from the result xml.

However, if the test framework didn't start in the first place, the result will be false positive.
Example: https://source.cloud.google.com/results/invocations/98d3e679-ec8a-40bd-9f36-88179747b0d6/targets

```
/home/kbuilder/.pyenv/versions/k8s_xds_test_runner/bin/python3: Error while finding module specification for 'tests.authz_test' (ModuleNotFoundError: No module named 'tests')
+ set +x
Failed test suites: 0

[ID: 3548168] Command finished after 625 secs, exit value: 0
```

* client_channel: fix crash when cancelling a watch after SHUTDOWN (#30885) (#30928)

* Support Python 3.11 (#30818) (#30944)

* Support Python 3.11

* Update build images for 3.11

* Whoopsie

* The architecture of this thing is garbage

* Silence ownership warning

* Account for change in git behavior

* Fix directory

* I am in great pain

* Update Windows and arm linux

* Agh

* Clean up

* Bump 1.49 branch to 1.49.0 (#30974)

* bump version to 1.49.0

* regenerate projects

* Update protobuf to v21.6 on 1.49.x (#31028)

* Update third_party/protobuf

* run tools/distrib/python/make_grpcio_tools.py

* update build_handwritten.yaml

* regenerate projects

* Bump v1.49.x to v1.49.1 (#31037)

* bump version to 1.49.1

* regenerate projects

* Automated change: Fix sanity tests

Co-authored-by: gnossen <gnossen@users.noreply.github.com>

* Fix ruby windows ucrt build (#31053)

Co-authored-by: apolcyn <apolcyn@google.com>
Co-authored-by: AJ Heller <hork@google.com>
Co-authored-by: Richard Belleville <rbellevi@google.com>
Co-authored-by: Sergii Tkachenko <sergiitk@google.com>
Co-authored-by: Mark D. Roth <roth@google.com>
Co-authored-by: Richard Belleville <gnossen@gmail.com>
Co-authored-by: gnossen <gnossen@users.noreply.github.com>
@jtattermusch jtattermusch mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@apolcyn apolcyn Awaiting requested review from apolcyn apolcyn is a code owner

Assignees

@sergiitk sergiitk

Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/Python per-call-memory/neutral per-channel-memory/neutral priority/P0/RELEASE BLOCKER release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnossen @sergiitk @grpc-kokoro