Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventEngineFactoryReset - remove custom factory and reset default engine #30554

Merged
merged 9 commits into from Sep 29, 2022

Conversation

drfloob
Copy link
Member

@drfloob drfloob commented Aug 10, 2022

/// Reset gRPC's EventEngine factory to the built-in default.
///
/// Applications that have called SetEventEngineFactory can remove their
/// custom factory using this method. The built-in EventEngine factories will be
/// used going forward. This has no affect on any EventEngines that were created
/// using the previous custom factory.

Note this was partially landed in a previous commit, but this adds the intended name and some tests.

@drfloob drfloob added the release notes: yes Indicates if PR needs to be in release notes label Aug 10, 2022
@drfloob drfloob requested a review from ctiller August 10, 2022 18:57
@drfloob
Copy link
Member Author

drfloob commented Sep 14, 2022

Depends on #30619 landing first.

@drfloob drfloob requested review from markdroth and removed request for ctiller September 28, 2022 22:25
@drfloob
Copy link
Member Author

drfloob commented Sep 29, 2022

This is ready to land

@drfloob drfloob merged commit 6cac641 into grpc:master Sep 29, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants