Grpc.Tools add support for env variable GRPC_PROTOC_PLUGIN (fix #27099) #30411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added environment variable GRPC_TOOL_PLUGIN to override the GRPC plugin path
jtattermusch
added
the
release notes: yes
jtattermusch
changed the title
| @@ -22,6 +22,10 @@ | |||
| <Target Name="gRPC_ResolvePluginFullPath" AfterTargets="Protobuf_ResolvePlatform"> | |||
| <PropertyGroup> | |||
| <!-- TODO(kkm): Do not use Protobuf_PackagedToolsPath, roll gRPC's own. --> | |||
|
|
|||
| <!-- First try environment variable. --> | |||
| <gRPC_PluginFullPath Condition=" '$(gRPC_PluginFullPath)' == '' ">$(GRPC_TOOL_PLUGIN)</gRPC_PluginFullPath> | |||
There was a problem hiding this comment.
The newly added logic looks good, but I think we should use a different name for the env variable.
How does these options sound?
GRPC_TOOLS_PLUGIN(at least the prefix matches the nuget name)GRPC_TOOLS_PROTOC_PLUGIN(even more specific)GRPC_PROTOC_PLUGIN(describes well what the thing is)PROTOBUF_PROTOC_PLUGIN(sincePROTOBUF_PROTOCis the env variable used for protoc binary - the name isn't great, but at least this would be consistent with the existing setting)
I'm leaning towards GRPC_PROTOC_PLUGIN.
tonydnewell
changed the title
jtattermusch
approved these changes
Aug 30, 2022
|
Test failures are unrelated to C# and this PR. |
|
(we are in the middle of a fixit and merging to the repository is disabled ATM, I'll merge once merging is re-enabled) |
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added environment variable GRPC_TOOL_PLUGIN to override the GRPC plugin path
See #27099