Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OutputOptions and GrpcOutputOptions (issue #25950) #30410

Merged
merged 1 commit into from Aug 17, 2022
Merged

Fix OutputOptions and GrpcOutputOptions (issue #25950) #30410

merged 1 commit into from Aug 17, 2022

Conversation

tonydnewell
Copy link
Contributor

Fix for OutputOptions and GrpcOutputOptions being ignored - issue #25950

The Grpc.Tools msbuild XML needed updating to include using the user-supplied options.

@tonydnewell tonydnewell mentioned this pull request Jul 26, 2022
Closed
@jtattermusch jtattermusch self-requested a review August 16, 2022 12:27
@jtattermusch jtattermusch self-assigned this Aug 16, 2022
@jtattermusch jtattermusch added the release notes: yes Indicates if PR needs to be in release notes label Aug 16, 2022
@jtattermusch jtattermusch changed the title issue 25950 fix OutputOptions and GrpcOutputOptions Fix OutputOptions and GrpcOutputOptions (issue #25950) Aug 16, 2022
@jtattermusch
Copy link
Contributor

CC @JamesNK

jtattermusch
jtattermusch approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

We should think about how to improve the current test suite for Grpc.Tools so that we can reliably test changes like this and we don't have to rely on manual testing (which is unrealiable and timeconsuming).

@jtattermusch
Copy link
Contributor

CC @apolcyn

@jtattermusch jtattermusch merged commit b85776b into grpc:master Aug 17, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees

@jtattermusch jtattermusch

Labels
imported Specifies if the PR has been imported to the internal repository lang/C# release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonydnewell @jtattermusch