Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update third_party/protobuf to 3.21.4 #30377

Merged
merged 11 commits into from
Aug 4, 2022
Merged

Update third_party/protobuf to 3.21.4 #30377

merged 11 commits into from
Aug 4, 2022

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Jul 21, 2022 •
edited

Change was created by the release automation script and then manually modified. See go/grpc-release
Additional modifications -

  • Use :well_known_type_protos instead of :well_known_protos
  • Update IWYU to get around bogus IWYU rules (Remove bogus IWYU pragma protocolbuffers/protobuf#10358)
  • Python
    • Drops support for Python 3.6.
    • Updates test infrastructure to install protobuf 4.X wheels (a major version bump)
    • Fixes a latent bug in the test runner where individual modules were loaded multiple times
    • Previously, this bug was benign since protobuf module loading was idempotent
    • AddSerializedFile now returns None on subsequent invocations
    • Regenerates generated code in examples/python/

Performing an early update of the protobuf submodule for 1.49.x

@yashykt yashykt added release notes: yes Indicates if PR needs to be in release notes lang/core labels Jul 21, 2022
@yashykt yashykt requested a review from apolcyn July 21, 2022 18:59
@yashykt yashykt mentioned this pull request Jul 22, 2022
Closed
gnossen and others added 2 commits August 3, 2022 16:15
@gnossen
Update Python for Protobuf 4.21 (#140)
6886c0f 
* Update protobuf dependency on grpcio-tools

* Off by one

* Drop python 3.6 support

* Try upgrading pip

* And in the other script

* Try to figure out if we're compatible with abi3

* See what we've already got installed

* Update the requirements.txt file I didn't know existed

* And here too

* See what's installed

* Let's try that again

* Remove

* Try to confirm version

* Let me see the generated code

* Fix non-Bazel test runner

* Work for all test directories

* Regenerate example protos

* Clean up

* Generate .pyi files

* Fix type checking and linting

* Exclude pyi files from isort
@yashykt
Upgrade to 3.21.4
50541aa
@yashykt yashykt changed the title Update third_party/protobuf to 3.21.3 Update third_party/protobuf to 3.21.4 Aug 4, 2022
@yashykt yashykt merged commit 41ec08c into grpc:master Aug 4, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Aug 4, 2022
@cretz cretz mentioned this pull request Sep 16, 2022
Merged
This was referenced Sep 16, 2022
Closed
Merged
@yashykt yashykt deleted the update_protobuf_202207211851 branch May 18, 2023 20:39
@XuanWang-Amos XuanWang-Amos mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnossen gnossen gnossen approved these changes

@veblush veblush veblush approved these changes

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@apolcyn apolcyn Awaiting requested review from apolcyn apolcyn is a code owner

Assignees
No one assigned
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/C# lang/core lang/ObjC lang/php lang/Python per-call-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yashykt @gnossen @veblush