Grpc.Tools: Parse warnings from libprotobuf (fix #27502) #30371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings and errors logged by some of the pluggins such as the csharp plugin are in a different format from other warnings etc logged by the protobuf compiler (the plugins use GOOGLE_LOG to log message). The parsing code in Grpc.Tools has been modified to correctly parse these so that warnings are no longer handled as errors.
jskeet
approved these changes
Jul 21, 2022
| // The filename and line logged by the plugins may not be useful to the | ||
| // end user as they are not the location in the proto file but rather | ||
| // in the source code for the plugin. Log them anyway as they may help in | ||
| // diagnositics. |
There was a problem hiding this comment.
Nit: diagnositics => diagnostics, here and below
jtattermusch
added
the
release notes: yes
jtattermusch
changed the title
jtattermusch
changed the title
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #27502
The warnings and errors logged by some of the plugins such as the csharp plugin are in a different format from other warnings etc logged by the protobuf compiler (the plugins use GOOGLE_LOG to log message).
The parsing code in Grpc.Tools has been modified to correctly parse these so that warnings are no longer handled as errors.
The unit tests have been extended and fixed (they did not notice if a test case did not match the expected log level).