Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Removed c++14 option from bazel.rc" #29750

Merged
merged 1 commit into from May 20, 2022
Merged

Conversation

veblush
Copy link
Contributor

@veblush veblush commented May 20, 2022

Reverts #29711

It turned out that -std=c++14 is required because bazel explicitly specifies it (e.g. link) Although this change generates warnings with MSVC but it's still fine because it just ignores and it will use c++14 by default anyway.

@veblush veblush added lang/core release notes: no Indicates if PR should not be in release notes labels May 20, 2022
@veblush veblush requested a review from ctiller May 20, 2022 20:49
@veblush veblush merged commit df53955 into master May 20, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label May 23, 2022
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request May 24, 2022
@meteorcloudy
Copy link

meteorcloudy commented Sep 21, 2022

This is forcing downstream projects which uses grpc to add build --cxxopt='-std=c++14' to their bazelrc file because grpc no longer builds without this flag:

./src/core/lib/gpr/useful.h:109:17: error: 'auto' not allowed in lambda parameter
      [&](const auto& x) {
                ^~~~
1 error generated.

e.g. google/flatbuffers#7535

Is it possible to fix this incompatibility?

@meteorcloudy
Copy link

Or you can move this flag to GRPC_DEFAULT_COPTS so that it also works when grpc is built as a dependency.

@stanley-cheung stanley-cheung deleted the revert-29711-bazel-cpp14 branch March 31, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build bloat/none imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants