[objc] GRPCErrorCode enum base type to int32_t #27908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennycd
added
lang/ObjC
platform/iOS
release notes: yes
sampajano
reviewed
Nov 2, 2021
| @@ -23,7 +23,7 @@ | |||
| * Note that a few of these are never produced by the gRPC libraries, but are of | |||
| * general utility for server applications to produce. | |||
| */ | |||
| typedef NS_ENUM(NSUInteger, GRPCErrorCode) { | |||
| typedef NS_ENUM(int32_t, GRPCErrorCode) { | |||
There was a problem hiding this comment.
Thanks Daniel! LGTM in general :)
2 thoughts:
-
Is this a non-breaking change for all clients?
-
There are a few other enums in this file, as well as throughout the codebase, which i wonder would benefit from the same improvement?
Thanks :)
There was a problem hiding this comment.
thanks, this change is non-breaking. This PR changes just the GRPCErrorCode enum. We will follow up with incremental changes to the rest of the enum when we made corresponding g3 patches.
There was a problem hiding this comment.
Ok thanks :)
(In general, for the sake of API consistency i'd prefer our APIs to use similar types if possible.. But it's fine with me since you're going to do a bunch of follow-ups soon :))
sampajano
approved these changes
Nov 2, 2021
dennycd
force-pushed
the
v2_api_update_2
branch
from
18c1e34
to
f1506ff
Compare
dennycd
added a commit
that referenced
this pull request
Nov 3, 2021
…)" This reverts commit 6b91698.
dennycd
added a commit
that referenced
this pull request
Nov 3, 2021
copybara-service
bot
added
the
imported
dennycd
added
release notes: no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating GRPCErrorCode base enum type from NSUInteger to int32_t to have better integer size consistency across various architectures (32/64).