Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[objc] GRPCMetadataDictionary convenient typedef #27845

Merged
merged 1 commit into from
Oct 29, 2021
Merged

[objc] GRPCMetadataDictionary convenient typedef #27845

merged 1 commit into from
Oct 29, 2021

Conversation

dennycd
Copy link
Contributor

@dennycd dennycd commented Oct 27, 2021 •
edited

Introduce a convenient typedef for metadata dictionary in the API with light-weight generics. This marks the expected type for the dictionary and will generate compiler warning if user input is not matched

  • Dictionary key is always NSString
  • Dictionary value must conforms to NSCoping protocol

grpc/grpc-ios#42

@dennycd dennycd added lang/ObjC platform/iOS release notes: no Indicates if PR should not be in release notes labels Oct 27, 2021
sampajano
sampajano approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Denny!

The change LGTM - and please only make sure this doesn't break any existing working clients (but i don't mind raising compilation errors to non-working clients.) :)

@dennycd
Copy link
Contributor Author

dennycd commented Oct 29, 2021

TGP check all green

@dennycd dennycd merged commit 3bc9147 into grpc:master Oct 29, 2021
@dennycd dennycd added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Oct 29, 2021
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 29, 2021
dennycd added a commit that referenced this pull request Oct 29, 2021
@dennycd
Revert "[objc] GRPCMetadataDictionary convenient typedef (#27845)"
53c3272 
This reverts commit 3bc9147.
@dennycd dennycd mentioned this pull request Oct 29, 2021
Merged
dennycd added a commit that referenced this pull request Oct 29, 2021
@dennycd
Revert "[objc] GRPCMetadataDictionary convenient typedef (#27845)" (#…
aafa926 
…27877)

This reverts commit 3bc9147.
dennycd added a commit that referenced this pull request Oct 29, 2021
@dennycd
Revert "Revert "[objc] GRPCMetadataDictionary convenient typedef (#27845
1901b2d 
)" (#27877)"

This reverts commit aafa926.
dennycd added a commit that referenced this pull request Nov 3, 2021
@dennycd
Revert "Revert "[objc] GRPCMetadataDictionary convenient typedef (#27845
011ce1a 
)" (#27877)"

This reverts commit aafa926.
dennycd added a commit that referenced this pull request Nov 3, 2021
@dennycd
Revert "Revert "[objc] GRPCMetadataDictionary convenient typedef (#27845
bc77067 
)" (#27877)"

This reverts commit aafa926.
dennycd added a commit that referenced this pull request Nov 3, 2021
@dennycd
Revert "Revert "[objc] GRPCMetadataDictionary convenient typedef (#27845
b1e6b1f 
)" (#27877)" (#27882)

This reverts commit aafa926.
@dennycd dennycd added release notes: no Indicates if PR should not be in release notes and removed release notes: yes Indicates if PR needs to be in release notes labels Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampajano sampajano sampajano approved these changes

@stanley-cheung stanley-cheung Awaiting requested review from stanley-cheung

Assignees
No one assigned
Labels
imported Specifies if the PR has been imported to the internal repository lang/ObjC platform/iOS release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dennycd @sampajano